diff mbox series

[3/3] ARM: dts: imx6qdl-apalis: Change to "adi,force-bt656-4"

Message ID 20241023144206.1099622-3-festevam@gmail.com (mailing list archive)
State New
Headers show
Series [1/3] media: dt-bindings: adv7180: Document 'adi,force-bt656-4' | expand

Commit Message

Fabio Estevam Oct. 23, 2024, 2:42 p.m. UTC 
From: Fabio Estevam <festevam@denx.de>

According to adv7180.yaml, the correct property name is
"adi,force-bt656-4".

Update it accordingly to fix several dt-schema warnings:

adv7280@21: 'adv,force-bt656-4' does not match any of the regexes: ...

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 arch/arm/boot/dts/nxp/imx/imx6qdl-apalis.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Krzysztof Kozlowski Oct. 24, 2024, 7:43 a.m. UTC | #1 
On Wed, Oct 23, 2024 at 11:42:06AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> According to adv7180.yaml, the correct property name is
> "adi,force-bt656-4".
> 
> Update it accordingly to fix several dt-schema warnings:
> 
> adv7280@21: 'adv,force-bt656-4' does not match any of the regexes: ...
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
>  arch/arm/boot/dts/nxp/imx/imx6qdl-apalis.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

This will affect other users of this DTS, which we try to avoid. Some
sort of analysis if this is used in BSD would be useful.

Best regards,
Krzysztof
Fabio Estevam Oct. 24, 2024, 11 a.m. UTC | #2 
Hi Krzysztof,

On Thu, Oct 24, 2024 at 4:43 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:

> This will affect other users of this DTS, which we try to avoid. Some
> sort of analysis if this is used in BSD would be useful.

Thanks for the suggestion.

I checked the BSD source code and there is no adv7180 driver available.
Krzysztof Kozlowski Oct. 24, 2024, 11:20 a.m. UTC | #3 
On 24/10/2024 13:00, Fabio Estevam wrote:
> Hi Krzysztof,
> 
> On Thu, Oct 24, 2024 at 4:43 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> 
>> This will affect other users of this DTS, which we try to avoid. Some
>> sort of analysis if this is used in BSD would be useful.
> 
> Thanks for the suggestion.
> 
> I checked the BSD source code and there is no adv7180 driver available.

OK, thanks. I think it would be useful to add above to commit msg.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-apalis.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-apalis.dtsi
index 1c72da417011..dffab5aa8b9c 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6qdl-apalis.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-apalis.dtsi
@@ -691,7 +691,7 @@  &i2c3 {
 
 	adv_7280: adv7280@21 {
 		compatible = "adi,adv7280";
-		adv,force-bt656-4;
+		adi,force-bt656-4;
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_ipu1_csi0>;
 		reg = <0x21>;