| Message ID | 6b914abf-b3ce-4baa-b4d7-f8da9a840a3f@stanley.mountain (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | RAS/AMD/FMPM: Remove some dead code | expand |
On Fri, Oct 25, 2024 at 10:08:34AM +0300, Dan Carpenter wrote: > Debugfs functions don't return NULL, they return error pointers. Debugfs > functions are slightly unusual because they're not supposed to be checked > for errors in the normal case. Delete these checks. > > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> > --- > drivers/ras/amd/fmpm.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/ras/amd/fmpm.c b/drivers/ras/amd/fmpm.c > index 90de737fbc90..3cde1fe17a7a 100644 > --- a/drivers/ras/amd/fmpm.c > +++ b/drivers/ras/amd/fmpm.c > @@ -956,12 +956,7 @@ static void setup_debugfs(void) > return; > > fmpm_dfs_dir = debugfs_create_dir("fmpm", dfs); > - if (!fmpm_dfs_dir) > - return; > - > fmpm_dfs_entries = debugfs_create_file("entries", 0400, fmpm_dfs_dir, NULL, &fmpm_fops); > - if (!fmpm_dfs_entries) > - debugfs_remove(fmpm_dfs_dir); > } > > static const struct x86_cpu_id fmpm_cpuids[] = { > -- Seems like we had the same idea. :) https://lore.kernel.org/r/20241024155503.GA965@yaz-khff2.amd.com Thanks, Yazen
On Fri, Oct 25, 2024 at 09:56:16AM -0400, Yazen Ghannam wrote: > On Fri, Oct 25, 2024 at 10:08:34AM +0300, Dan Carpenter wrote: > > Debugfs functions don't return NULL, they return error pointers. Debugfs > > functions are slightly unusual because they're not supposed to be checked > > for errors in the normal case. Delete these checks. > > > > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> > > --- > > drivers/ras/amd/fmpm.c | 5 ----- > > 1 file changed, 5 deletions(-) > > > > diff --git a/drivers/ras/amd/fmpm.c b/drivers/ras/amd/fmpm.c > > index 90de737fbc90..3cde1fe17a7a 100644 > > --- a/drivers/ras/amd/fmpm.c > > +++ b/drivers/ras/amd/fmpm.c > > @@ -956,12 +956,7 @@ static void setup_debugfs(void) > > return; > > > > fmpm_dfs_dir = debugfs_create_dir("fmpm", dfs); > > - if (!fmpm_dfs_dir) > > - return; > > - > > fmpm_dfs_entries = debugfs_create_file("entries", 0400, fmpm_dfs_dir, NULL, &fmpm_fops); > > - if (!fmpm_dfs_entries) > > - debugfs_remove(fmpm_dfs_dir); > > } > > > > static const struct x86_cpu_id fmpm_cpuids[] = { > > -- > > Seems like we had the same idea. :) > > https://lore.kernel.org/r/20241024155503.GA965@yaz-khff2.amd.com > Ah. Good. To me it's always encouraging when people end up writing basically the exact same patch. regards, dan carpenter
diff --git a/drivers/ras/amd/fmpm.c b/drivers/ras/amd/fmpm.c index 90de737fbc90..3cde1fe17a7a 100644 --- a/drivers/ras/amd/fmpm.c +++ b/drivers/ras/amd/fmpm.c @@ -956,12 +956,7 @@ static void setup_debugfs(void) return; fmpm_dfs_dir = debugfs_create_dir("fmpm", dfs); - if (!fmpm_dfs_dir) - return; - fmpm_dfs_entries = debugfs_create_file("entries", 0400, fmpm_dfs_dir, NULL, &fmpm_fops); - if (!fmpm_dfs_entries) - debugfs_remove(fmpm_dfs_dir); } static const struct x86_cpu_id fmpm_cpuids[] = {
Debugfs functions don't return NULL, they return error pointers. Debugfs functions are slightly unusual because they're not supposed to be checked for errors in the normal case. Delete these checks. Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> --- drivers/ras/amd/fmpm.c | 5 ----- 1 file changed, 5 deletions(-)