| Message ID | ZxvBfDuqSC_TEM78@carbonx1 (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | [GIT,PULL] fbdev late fixes for v6.12-rc5 | expand |
The pull request you sent on Fri, 25 Oct 2024 18:04:12 +0200:
> http://git.kernel.org/pub/scm/linux/kernel/git/deller/linux-fbdev.git tags/fbdev-for-6.12-rc5
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/86d6688e6099594e732841ddad69fad196e95245
Thank you!
On Fri, 25 Oct 2024 at 09:04, Helge Deller <deller@kernel.org> wrote: > > It's mostly about build warning fixes with cornercase CONFIG settings > and one big patch which removes the now unused da8xx fbdev driver. So I pulled this, but only later noticed that some of the Kconfig "fixes" are anything but. At least commit 447794e44744 ("fbdev: sstfb: Make CONFIG_FB_DEVICE optional") is not fixing anything, and very questionable. For no reason at all does it seem to enable 30-year old hardware in a new configuration. There were no build issues before, the build issues that existed were *introduced* by broken early versions of this patch. Does anybody even *have* that hardware? Why were those pointless changes made? Sure, the Voodoo1 was the bomb back in 1996 if you wanted to run hw-accelerated Quake, but in 2024, this change should have had more explanation for why anybody would care about the CONFIG_FB_DEVICE dependency. And in no case should it have been marked as a "fix". Linus
Hi Linus, On 10/25/24 20:31, Linus Torvalds wrote: > On Fri, 25 Oct 2024 at 09:04, Helge Deller <deller@kernel.org> wrote: >> >> It's mostly about build warning fixes with cornercase CONFIG settings >> and one big patch which removes the now unused da8xx fbdev driver. > > So I pulled this, but only later noticed that some of the Kconfig > "fixes" are anything but. > > At least commit 447794e44744 ("fbdev: sstfb: Make CONFIG_FB_DEVICE > optional") is not fixing anything, and very questionable. > > For no reason at all does it seem to enable 30-year old hardware in a > new configuration. > > There were no build issues before, the build issues that existed were > *introduced* by broken early versions of this patch. That patch was the one I meant with "fixes [for] cornercase CONFIG settings". But you are right that there aren't any issues fixed by this patch. > Does anybody even *have* that hardware? I do have a few of those (Voodoo2). Actually one is built-into one of my parisc machines. > Why were those pointless changes made? When I accepted this patch I did not find it useless. Maybe there are people who really enables Voodoo driver although they prefer DRM. Maybe they don't even know the difference. I applied it because I don't want compilation to fail at all (which I see I was wrong in). > Sure, the Voodoo1 was the bomb back in 1996 if you wanted to run > hw-accelerated Quake, but in 2024, this change should have had more > explanation for why anybody would care about the CONFIG_FB_DEVICE > dependency. Ok. Btw, you will be astonished if you check the prices of those cards on ebay nowadays. > And in no case should it have been marked as a "fix". Ok. Do you want me to send a revert for this specific patch? FWIW, just a few hours before I sent the pull request I did complain about a similar patch (which I did not apply): https://lore.kernel.org/linux-fbdev/7aabca78-dd34-4819-8a63-105d1a4cb4ba@gmx.de/T/#m070c6ba1047d26b856b0d6ac43592fc7b6f95518 Helge
On Fri, 25 Oct 2024 at 12:36, Helge Deller <deller@gmx.de> wrote: > > Do you want me to send a revert for this specific patch? No, it's in now, more churn this time around just makes it worse. I just don't want to see these kinds of non-fixes in the future. Linus
Hi Linus, would you please pull a few late fbdev fixes ? It's mostly about build warning fixes with cornercase CONFIG settings and one big patch which removes the now unused da8xx fbdev driver. Those patches have been in for-next for the last 10 days without issues (Arnd's patch shows a later date because I added a R-b tag). Thanks, Helge ---------------------------------------------------------------- The following changes since commit 8e929cb546ee42c9a61d24fae60605e9e3192354: Linux 6.12-rc3 (2024-10-13 14:33:32 -0700) are available in the Git repository at: http://git.kernel.org/pub/scm/linux/kernel/git/deller/linux-fbdev.git tags/fbdev-for-6.12-rc5 for you to fetch changes up to 51521d2e2c35959cc70a62ccddf694965e29c950: fbdev: wm8505fb: select CONFIG_FB_IOMEM_FOPS (2024-10-21 11:16:51 +0200) ---------------------------------------------------------------- fbdev fixes for 6.12-rc5: - Fix some build warnings and failures with CONFIG_FB_IOMEM_FOPS and CONFIG_FB_DEVICE - Remove the da8xx fbdev driver - Constify struct sbus_mmap_map and fix indentation warning ---------------------------------------------------------------- Arnd Bergmann (1): fbdev: wm8505fb: select CONFIG_FB_IOMEM_FOPS Bartosz Golaszewski (1): fbdev: da8xx: remove the driver Christophe JAILLET (1): fbdev: Constify struct sbus_mmap_map Gonzalo Silvalde Blanco (1): fbdev: sstfb: Make CONFIG_FB_DEVICE optional SurajSonawane2415 (1): fbdev: nvidiafb: fix inconsistent indentation warning drivers/video/fbdev/Kconfig | 15 +- drivers/video/fbdev/Makefile | 1 - drivers/video/fbdev/bw2.c | 2 +- drivers/video/fbdev/cg14.c | 2 +- drivers/video/fbdev/cg3.c | 2 +- drivers/video/fbdev/cg6.c | 2 +- drivers/video/fbdev/da8xx-fb.c | 1665 ------------------------------------ drivers/video/fbdev/ffb.c | 2 +- drivers/video/fbdev/leo.c | 2 +- drivers/video/fbdev/nvidia/nv_hw.c | 8 +- drivers/video/fbdev/p9100.c | 2 +- drivers/video/fbdev/sbuslib.c | 2 +- drivers/video/fbdev/sbuslib.h | 2 +- drivers/video/fbdev/sstfb.c | 9 +- drivers/video/fbdev/tcx.c | 2 +- include/video/da8xx-fb.h | 94 -- 16 files changed, 22 insertions(+), 1790 deletions(-) delete mode 100644 drivers/video/fbdev/da8xx-fb.c delete mode 100644 include/video/da8xx-fb.h