diff mbox series

[2/2] mmc: sdhci-pci-gli: GL9767: Fix low power mode in the SD Express process

Message ID 20241025060017.1663697-2-benchuanggli@gmail.com (mailing list archive)
State New
Headers show
Series [1/2] mmc: sdhci-pci-gli: GL9767: Fix low power mode on the set clock function | expand

Commit Message

Ben Chuang Oct. 25, 2024, 6 a.m. UTC
From: Ben Chuang <ben.chuang@genesyslogic.com.tw>

When starting the SD Express process, the low power negotiation mode will
be disabled, so we need to re-enable it after switching back to SD mode.

Fixes: 0e92aec2efa0 ("mmc: sdhci-pci-gli: Add support SD Express card for GL9767")
Signed-off-by: Ben Chuang <benchuanggli@gmail.com>
Signed-off-by: Ben Chuang <ben.chuang@genesyslogic.com.tw>
---
 drivers/mmc/host/sdhci-pci-gli.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Ulf Hansson Oct. 28, 2024, 11:43 a.m. UTC | #1
On Fri, 25 Oct 2024 at 08:01, Ben Chuang <benchuanggli@gmail.com> wrote:
>
> From: Ben Chuang <ben.chuang@genesyslogic.com.tw>
>
> When starting the SD Express process, the low power negotiation mode will
> be disabled, so we need to re-enable it after switching back to SD mode.
>
> Fixes: 0e92aec2efa0 ("mmc: sdhci-pci-gli: Add support SD Express card for GL9767")
> Signed-off-by: Ben Chuang <benchuanggli@gmail.com>

I am dropping this SoB, as we agreed for patch1 too.

> Signed-off-by: Ben Chuang <ben.chuang@genesyslogic.com.tw>

Applied for fixes and by adding a stable tag, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/sdhci-pci-gli.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/mmc/host/sdhci-pci-gli.c b/drivers/mmc/host/sdhci-pci-gli.c
> index 22a927ce2c88..68ce4920e01e 100644
> --- a/drivers/mmc/host/sdhci-pci-gli.c
> +++ b/drivers/mmc/host/sdhci-pci-gli.c
> @@ -1068,6 +1068,9 @@ static int gl9767_init_sd_express(struct mmc_host *mmc, struct mmc_ios *ios)
>                 sdhci_writew(host, value, SDHCI_CLOCK_CONTROL);
>         }
>
> +       pci_read_config_dword(pdev, PCIE_GLI_9767_CFG, &value);
> +       value &= ~PCIE_GLI_9767_CFG_LOW_PWR_OFF;
> +       pci_write_config_dword(pdev, PCIE_GLI_9767_CFG, value);
>         gl9767_vhs_read(pdev);
>
>         return 0;
> --
> 2.47.0
>
diff mbox series

Patch

diff --git a/drivers/mmc/host/sdhci-pci-gli.c b/drivers/mmc/host/sdhci-pci-gli.c
index 22a927ce2c88..68ce4920e01e 100644
--- a/drivers/mmc/host/sdhci-pci-gli.c
+++ b/drivers/mmc/host/sdhci-pci-gli.c
@@ -1068,6 +1068,9 @@  static int gl9767_init_sd_express(struct mmc_host *mmc, struct mmc_ios *ios)
 		sdhci_writew(host, value, SDHCI_CLOCK_CONTROL);
 	}
 
+	pci_read_config_dword(pdev, PCIE_GLI_9767_CFG, &value);
+	value &= ~PCIE_GLI_9767_CFG_LOW_PWR_OFF;
+	pci_write_config_dword(pdev, PCIE_GLI_9767_CFG, value);
 	gl9767_vhs_read(pdev);
 
 	return 0;