| Message ID | 20241028115850.3409893-11-linyunsheng@huawei.com (mailing list archive) |
|---|---|
| State | RFC |
| Headers | show |
| Series | Replace page_frag with page_frag_cache (Part-2) | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Guessing tree name failed - patch did not apply, async |
On Mon, 28 Oct 2024 19:58:50 +0800 Yunsheng Lin wrote:
> +M: Yunsheng Lin <linyunsheng@huawei.com>
Why is this line still here? You asked for a second opinion
and you got one from Paolo.
On 2024/10/29 7:27, Jakub Kicinski wrote: > On Mon, 28 Oct 2024 19:58:50 +0800 Yunsheng Lin wrote: >> +M: Yunsheng Lin <linyunsheng@huawei.com> > > Why is this line still here? You asked for a second opinion > and you got one from Paolo. Because of the reason below? https://lore.kernel.org/all/159495c8-71be-4a11-8c49-d528e8154841@huawei.com/
On Tue, 29 Oct 2024 17:40:08 +0800 Yunsheng Lin wrote: > On 2024/10/29 7:27, Jakub Kicinski wrote: > > On Mon, 28 Oct 2024 19:58:50 +0800 Yunsheng Lin wrote: > >> +M: Yunsheng Lin <linyunsheng@huawei.com> > > > > Why is this line still here? You asked for a second opinion > > and you got one from Paolo. > > Because of the reason below? > https://lore.kernel.org/all/159495c8-71be-4a11-8c49-d528e8154841@huawei.com/ What is the reason in that link? You try to argue that the convention doesn't exist or that your case is different? The maintainer tells you their opinion in context of the posting. It seems like you're more motivated by getting into MAINTAINERS than by the work itself :/
On 2024/10/29 22:33, Jakub Kicinski wrote: > On Tue, 29 Oct 2024 17:40:08 +0800 Yunsheng Lin wrote: >> On 2024/10/29 7:27, Jakub Kicinski wrote: >>> On Mon, 28 Oct 2024 19:58:50 +0800 Yunsheng Lin wrote: >>>> +M: Yunsheng Lin <linyunsheng@huawei.com> >>> >>> Why is this line still here? You asked for a second opinion >>> and you got one from Paolo. >> >> Because of the reason below? >> https://lore.kernel.org/all/159495c8-71be-4a11-8c49-d528e8154841@huawei.com/ > > What is the reason in that link? You try to argue that the convention > doesn't exist or that your case is different? The maintainer tells you > their opinion in context of the posting. I just argue that it seems natural and reasonable that someone being willing and able to turn page_frag into a subsystem or library might become the co-maintainer if she/he is also willing to co-maintain it. > > It seems like you're more motivated by getting into MAINTAINERS than > by the work itself :/ For the 'MAINTAINERS ' part, I guess we all want some acknowledge in some way for the work if that is the 'motivated ' you are referring to. For the 'work itself' part, my previous work of supporting frag API, unifying frag & non-frag API for page_pool, removing page frag implementation in vhost_net and recent trying of fixing IOMMU crash problem all seem to be motivated more by getting into MAINTAINERS in your eyes? With all due respect, it would be good to have less of speculation like above and focus on more technical discussion.
diff --git a/MAINTAINERS b/MAINTAINERS index f39ab140710f..9f84f2e901f5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -17399,6 +17399,18 @@ F: mm/page-writeback.c F: mm/readahead.c F: mm/truncate.c +PAGE FRAG +M: Alexander Duyck <alexander.duyck@gmail.com> +M: Yunsheng Lin <linyunsheng@huawei.com> +L: linux-mm@kvack.org +L: netdev@vger.kernel.org +S: Supported +F: Documentation/mm/page_frags.rst +F: include/linux/page_frag_cache.h +F: mm/page_frag_cache.c +F: tools/testing/selftests/mm/page_frag/ +F: tools/testing/selftests/mm/test_page_frag.sh + PAGE POOL M: Jesper Dangaard Brouer <hawk@kernel.org> M: Ilias Apalodimas <ilias.apalodimas@linaro.org>
After this patchset, page_frag is a small subsystem/library on its own, so add an entry in MAINTAINERS to indicate the new subsystem/library's maintainer, maillist, status and file lists of page_frag. Alexander is the original author of page_frag, add him in the MAINTAINERS too. CC: Alexander Duyck <alexander.duyck@gmail.com> CC: Andrew Morton <akpm@linux-foundation.org> CC: Linux-MM <linux-mm@kvack.org> Signed-off-by: Yunsheng Lin <linyunsheng@huawei.com> --- MAINTAINERS | 12 ++++++++++++ 1 file changed, 12 insertions(+)