| Message ID | 20241027-spi-v3-2-42e81723bbcc@nxp.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | spi-nor: add optional vcc-supply and enable it for i.MX93 | expand |
On 24-10-27, Peng Fan (OSS) wrote: > From: Peng Fan <peng.fan@nxp.com> > > SPI NOR flashes needs power supply to work properly. The power supply > maybe software controllable per board design. So add the support > for an vcc-supply regulator. > > Signed-off-by: Peng Fan <peng.fan@nxp.com> Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>
On 10/27/24 12:16 PM, Peng Fan (OSS) wrote: > From: Peng Fan <peng.fan@nxp.com> > > SPI NOR flashes needs power supply to work properly. The power supply > maybe software controllable per board design. So add the support > for an vcc-supply regulator. > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > --- > drivers/mtd/spi-nor/core.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c > index b6f374ded390a0c0429a61dd0579204e0e98bfa1..d95427c4f4d0839c5df348eeddea59582ef99d9d 100644 > --- a/drivers/mtd/spi-nor/core.c > +++ b/drivers/mtd/spi-nor/core.c > @@ -17,6 +17,7 @@ > #include <linux/mtd/spi-nor.h> > #include <linux/mutex.h> > #include <linux/of_platform.h> > +#include <linux/regulator/consumer.h> > #include <linux/sched/task_stack.h> > #include <linux/sizes.h> > #include <linux/slab.h> > @@ -3465,6 +3466,10 @@ int spi_nor_scan(struct spi_nor *nor, const char *name, > if (!nor->bouncebuf) > return -ENOMEM; > > + ret = devm_regulator_get_enable(dev, "vcc"); > + if (ret) > + return ret; This is all looking good, but please move it to spi_nor_probe(). All the SPI NOR controllers need to move to spi/. We stopped adding support for the SPI NOR controllers few years ago. > + > ret = spi_nor_hw_reset(nor); > if (ret) > return ret; >
diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c index b6f374ded390a0c0429a61dd0579204e0e98bfa1..d95427c4f4d0839c5df348eeddea59582ef99d9d 100644 --- a/drivers/mtd/spi-nor/core.c +++ b/drivers/mtd/spi-nor/core.c @@ -17,6 +17,7 @@ #include <linux/mtd/spi-nor.h> #include <linux/mutex.h> #include <linux/of_platform.h> +#include <linux/regulator/consumer.h> #include <linux/sched/task_stack.h> #include <linux/sizes.h> #include <linux/slab.h> @@ -3465,6 +3466,10 @@ int spi_nor_scan(struct spi_nor *nor, const char *name, if (!nor->bouncebuf) return -ENOMEM; + ret = devm_regulator_get_enable(dev, "vcc"); + if (ret) + return ret; + ret = spi_nor_hw_reset(nor); if (ret) return ret;