| Message ID | cover.1730193891.git.jani.nikula@intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm/i915: add dedicated lock for each sideband | expand |
On Tue, 2024-10-29 at 11:25 +0200, Jani Nikula wrote: > It's misleading to use the same sideband mutex for LPT/WPT IOSF, > VLV/CHV > IOSF, and punit. Add dedicated locks for clarity. For the whole series: Reviewed-by: Jouni Högander <jouni.hogander@intel.com> > > Jani Nikula (4): > drm/i915/sbi: add intel_sbi_{lock,unlock}() > drm/i915/sbi: add a dedicated mutex for LPT/WPT IOSF sideband > drm/i915: add a dedicated mutex for VLV/CHV IOSF sideband > drm/i915: hide VLV PUNIT IOSF sideband qos handling better > > .../gpu/drm/i915/display/intel_pch_refclk.c | 26 ++++++++--------- > drivers/gpu/drm/i915/i915_driver.c | 8 ++++-- > drivers/gpu/drm/i915/i915_drv.h | 10 ++++++- > drivers/gpu/drm/i915/intel_sbi.c | 22 ++++++++++++++- > drivers/gpu/drm/i915/intel_sbi.h | 4 +++ > drivers/gpu/drm/i915/vlv_sideband.c | 28 +++++++++++++++-- > -- > drivers/gpu/drm/i915/vlv_sideband.h | 3 ++ > 7 files changed, 79 insertions(+), 22 deletions(-) >
On Wed, 30 Oct 2024, Patchwork <patchwork@emeril.freedesktop.org> wrote: > == Series Details == > > Series: drm/i915: add dedicated lock for each sideband (rev3) > URL : https://patchwork.freedesktop.org/series/139437/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_15607 -> Patchwork_139437v3 > ==================================================== > > Summary > ------- > > **FAILURE** > > Serious unknown changes coming with Patchwork_139437v3 absolutely need to be > verified manually. > > If you think the reported changes have nothing to do with the changes > introduced in Patchwork_139437v3, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them > to document this new failure mode, which will reduce false positives in CI. > > External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_139437v3/index.html > > Participating hosts (47 -> 46) > ------------------------------ > > Missing (1): fi-snb-2520m > > Possible new issues > ------------------- > > Here are the unknown changes that may have been introduced in Patchwork_139437v3: > > ### IGT changes ### > > #### Possible regressions #### > > * igt@i915_selftest@live: > - bat-jsl-1: [PASS][1] -> [DMESG-WARN][2] +1 other test dmesg-warn > [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15607/bat-jsl-1/igt@i915_selftest@live.html > [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_139437v3/bat-jsl-1/igt@i915_selftest@live.html Unrelated. > > > Known issues > ------------ > > Here are the changes found in Patchwork_139437v3 that come from known issues: > > ### IGT changes ### > > #### Possible fixes #### > > * igt@i915_selftest@live: > - bat-mtlp-8: [ABORT][3] ([i915#12133] / [i915#12216]) -> [PASS][4] > [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15607/bat-mtlp-8/igt@i915_selftest@live.html > [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_139437v3/bat-mtlp-8/igt@i915_selftest@live.html > > * igt@i915_selftest@live@workarounds: > - bat-mtlp-8: [ABORT][5] ([i915#12216]) -> [PASS][6] > [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15607/bat-mtlp-8/igt@i915_selftest@live@workarounds.html > [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_139437v3/bat-mtlp-8/igt@i915_selftest@live@workarounds.html > > * igt@kms_chamelium_frames@dp-crc-fast: > - bat-dg2-13: [DMESG-WARN][7] ([i915#12253]) -> [PASS][8] > [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15607/bat-dg2-13/igt@kms_chamelium_frames@dp-crc-fast.html > [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_139437v3/bat-dg2-13/igt@kms_chamelium_frames@dp-crc-fast.html > > > [i915#12133]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12133 > [i915#12216]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12216 > [i915#12253]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12253 > > > Build changes > ------------- > > * Linux: CI_DRM_15607 -> Patchwork_139437v3 > > CI-20190529: 20190529 > CI_DRM_15607: fb2691707e2d5a8c704ae5e48bc5a314a308b0e0 @ git://anongit.freedesktop.org/gfx-ci/linux > IGT_8087: 7abd9c49a49a9ff1f3300d7c51a92a5af8a789f1 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git > Patchwork_139437v3: fb2691707e2d5a8c704ae5e48bc5a314a308b0e0 @ git://anongit.freedesktop.org/gfx-ci/linux > > == Logs == > > For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_139437v3/index.html
On Wed, 30 Oct 2024, Jani Nikula <jani.nikula@intel.com> wrote: > On Wed, 30 Oct 2024, Patchwork <patchwork@emeril.freedesktop.org> wrote: >> == Series Details == >> >> Series: drm/i915: add dedicated lock for each sideband (rev3) >> URL : https://patchwork.freedesktop.org/series/139437/ >> State : failure >> >> == Summary == >> >> CI Bug Log - changes from CI_DRM_15607 -> Patchwork_139437v3 >> ==================================================== >> >> Summary >> ------- >> >> **FAILURE** >> >> Serious unknown changes coming with Patchwork_139437v3 absolutely need to be >> verified manually. >> >> If you think the reported changes have nothing to do with the changes >> introduced in Patchwork_139437v3, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them >> to document this new failure mode, which will reduce false positives in CI. >> >> External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_139437v3/index.html >> >> Participating hosts (47 -> 46) >> ------------------------------ >> >> Missing (1): fi-snb-2520m >> >> Possible new issues >> ------------------- >> >> Here are the unknown changes that may have been introduced in Patchwork_139437v3: >> >> ### IGT changes ### >> >> #### Possible regressions #### >> >> * igt@i915_selftest@live: >> - bat-jsl-1: [PASS][1] -> [DMESG-WARN][2] +1 other test dmesg-warn >> [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15607/bat-jsl-1/igt@i915_selftest@live.html >> [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_139437v3/bat-jsl-1/igt@i915_selftest@live.html > > Unrelated. And by that I mean, please re-report. > >> >> >> Known issues >> ------------ >> >> Here are the changes found in Patchwork_139437v3 that come from known issues: >> >> ### IGT changes ### >> >> #### Possible fixes #### >> >> * igt@i915_selftest@live: >> - bat-mtlp-8: [ABORT][3] ([i915#12133] / [i915#12216]) -> [PASS][4] >> [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15607/bat-mtlp-8/igt@i915_selftest@live.html >> [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_139437v3/bat-mtlp-8/igt@i915_selftest@live.html >> >> * igt@i915_selftest@live@workarounds: >> - bat-mtlp-8: [ABORT][5] ([i915#12216]) -> [PASS][6] >> [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15607/bat-mtlp-8/igt@i915_selftest@live@workarounds.html >> [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_139437v3/bat-mtlp-8/igt@i915_selftest@live@workarounds.html >> >> * igt@kms_chamelium_frames@dp-crc-fast: >> - bat-dg2-13: [DMESG-WARN][7] ([i915#12253]) -> [PASS][8] >> [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15607/bat-dg2-13/igt@kms_chamelium_frames@dp-crc-fast.html >> [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_139437v3/bat-dg2-13/igt@kms_chamelium_frames@dp-crc-fast.html >> >> >> [i915#12133]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12133 >> [i915#12216]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12216 >> [i915#12253]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12253 >> >> >> Build changes >> ------------- >> >> * Linux: CI_DRM_15607 -> Patchwork_139437v3 >> >> CI-20190529: 20190529 >> CI_DRM_15607: fb2691707e2d5a8c704ae5e48bc5a314a308b0e0 @ git://anongit.freedesktop.org/gfx-ci/linux >> IGT_8087: 7abd9c49a49a9ff1f3300d7c51a92a5af8a789f1 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git >> Patchwork_139437v3: fb2691707e2d5a8c704ae5e48bc5a314a308b0e0 @ git://anongit.freedesktop.org/gfx-ci/linux >> >> == Logs == >> >> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_139437v3/index.html
It's misleading to use the same sideband mutex for LPT/WPT IOSF, VLV/CHV IOSF, and punit. Add dedicated locks for clarity. Jani Nikula (4): drm/i915/sbi: add intel_sbi_{lock,unlock}() drm/i915/sbi: add a dedicated mutex for LPT/WPT IOSF sideband drm/i915: add a dedicated mutex for VLV/CHV IOSF sideband drm/i915: hide VLV PUNIT IOSF sideband qos handling better .../gpu/drm/i915/display/intel_pch_refclk.c | 26 ++++++++--------- drivers/gpu/drm/i915/i915_driver.c | 8 ++++-- drivers/gpu/drm/i915/i915_drv.h | 10 ++++++- drivers/gpu/drm/i915/intel_sbi.c | 22 ++++++++++++++- drivers/gpu/drm/i915/intel_sbi.h | 4 +++ drivers/gpu/drm/i915/vlv_sideband.c | 28 +++++++++++++++---- drivers/gpu/drm/i915/vlv_sideband.h | 3 ++ 7 files changed, 79 insertions(+), 22 deletions(-)