| Message ID | 20241028190628.257249-5-mirela.rabulea@nxp.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | media: i2c: Add OX05B1S camera sensor driver | expand |
On 28/10/2024 20:06, Mirela Rabulea wrote: > Add another compatible for OS08A20 sensor. > > Signed-off-by: Mirela Rabulea <mirela.rabulea@nxp.com> > --- > Documentation/devicetree/bindings/media/i2c/ovti,ox05b1s.yaml | 1 + This is part of the original binding. Submit complete binding in one patch. A nit, subject: drop second/last, redundant "bindings". The "dt-bindings" prefix is already stating that these are bindings. See also: https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18 <form letter> Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. Tools like b4 or scripts/get_maintainer.pl provide you proper list of people, so fix your workflow. Tools might also fail if you work on some ancient tree (don't, instead use mainline) or work on fork of kernel (don't, instead use mainline). Just use b4 and everything should be fine, although remember about `b4 prep --auto-to-cc` if you added new patches to the patchset. You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time. Please kindly resend and include all necessary To/Cc entries. </form letter> Best regards, Krzysztof
On 29.10.2024 08:17, Krzysztof Kozlowski wrote: > On 28/10/2024 20:06, Mirela Rabulea wrote: >> Add another compatible for OS08A20 sensor. >> >> Signed-off-by: Mirela Rabulea <mirela.rabulea@nxp.com> >> --- >> Documentation/devicetree/bindings/media/i2c/ovti,ox05b1s.yaml | 1 + > This is part of the original binding. Submit complete binding in one patch. Hi Krzysztof, Should I squash this patch into #1? I sent the patch #1, #2 and #3 for the OX05B1S sensor, and patches #4 and #5 as additions for another sensor, OS08A20. Thanks, Mirela
On 29/10/2024 15:02, Mirela Rabulea wrote: > > On 29.10.2024 08:17, Krzysztof Kozlowski wrote: >> On 28/10/2024 20:06, Mirela Rabulea wrote: >>> Add another compatible for OS08A20 sensor. >>> >>> Signed-off-by: Mirela Rabulea <mirela.rabulea@nxp.com> >>> --- >>> Documentation/devicetree/bindings/media/i2c/ovti,ox05b1s.yaml | 1 + >> This is part of the original binding. Submit complete binding in one patch. > > Hi Krzysztof, > > Should I squash this patch into #1? Yes, please. Splitting initial binding into such small chunks is not necessary. > > I sent the patch #1, #2 and #3 for the OX05B1S sensor, and patches #4 > and #5 as additions for another sensor, OS08A20. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ox05b1s.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ox05b1s.yaml index d47e1950f24d..a645c34dcc22 100644 --- a/Documentation/devicetree/bindings/media/i2c/ovti,ox05b1s.yaml +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ox05b1s.yaml @@ -20,6 +20,7 @@ properties: items: - enum: - ovti,ox05b1s + - ovti,os08a20 reg: maxItems: 1
Add another compatible for OS08A20 sensor. Signed-off-by: Mirela Rabulea <mirela.rabulea@nxp.com> --- Documentation/devicetree/bindings/media/i2c/ovti,ox05b1s.yaml | 1 + 1 file changed, 1 insertion(+)