mbox series

[0/2] Convert the BananaPi and OrangePi Avacodo tests

Message ID 20241029092440.25021-1-thuth@redhat.com (mailing list archive)
Headers show
Series Convert the BananaPi and OrangePi Avacodo tests | expand

Message

Thomas Huth Oct. 29, 2024, 9:24 a.m. UTC
Some of the URLs in the Avocado tests stopped working since the
original assets have been removed from the servers or moved location,
see:

 https://lore.kernel.org/qemu-devel/CACPK8Xc=jsz5iT_WR7s-rcu1cRzryiK+-0o=6vUK_D_qMMrP3A@mail.gmail.com/

Since we are currently in progress of converting the Avocado tests
to the new functional framework, this is a good opportunity to convert
these tests and adjust the URLs (and hashsums) along the way to make
these tests work again.

Thomas Huth (2):
  tests/functional: Convert BananaPi tests to the functional framework
  tests/functional: Convert the OrangePi tests to the functional
    framework

 MAINTAINERS                           |   1 +
 tests/avocado/boot_linux_console.py   | 411 --------------------------
 tests/functional/meson.build          |   4 +
 tests/functional/qemu_test/utils.py   |  21 ++
 tests/functional/test_arm_bpim2u.py   | 206 +++++++++++++
 tests/functional/test_arm_orangepi.py | 270 +++++++++++++++++
 6 files changed, 502 insertions(+), 411 deletions(-)
 create mode 100755 tests/functional/test_arm_bpim2u.py
 create mode 100755 tests/functional/test_arm_orangepi.py

Comments

Pierrick Bouvier Oct. 29, 2024, 4:31 p.m. UTC | #1
Hi Thomas,

On 10/29/24 02:24, Thomas Huth wrote:
> Some of the URLs in the Avocado tests stopped working since the
> original assets have been removed from the servers or moved location,
> see:
> 
>   https://lore.kernel.org/qemu-devel/CACPK8Xc=jsz5iT_WR7s-rcu1cRzryiK+-0o=6vUK_D_qMMrP3A@mail.gmail.com/
> 
> Since we are currently in progress of converting the Avocado tests
> to the new functional framework, this is a good opportunity to convert
> these tests and adjust the URLs (and hashsums) along the way to make
> these tests work again.
> 
> Thomas Huth (2):
>    tests/functional: Convert BananaPi tests to the functional framework
>    tests/functional: Convert the OrangePi tests to the functional
>      framework
> 
>   MAINTAINERS                           |   1 +
>   tests/avocado/boot_linux_console.py   | 411 --------------------------
>   tests/functional/meson.build          |   4 +
>   tests/functional/qemu_test/utils.py   |  21 ++
>   tests/functional/test_arm_bpim2u.py   | 206 +++++++++++++
>   tests/functional/test_arm_orangepi.py | 270 +++++++++++++++++
>   6 files changed, 502 insertions(+), 411 deletions(-)
>   create mode 100755 tests/functional/test_arm_bpim2u.py
>   create mode 100755 tests/functional/test_arm_orangepi.py
> 

I have a general question regarding tests in QEMU.
Is the current goal to convert all avocado tests to functional ones, and 
then remove avocado from codebase?

Thanks,
Pierrick
Thomas Huth Oct. 29, 2024, 4:50 p.m. UTC | #2
On 29/10/2024 17.31, Pierrick Bouvier wrote:
> Hi Thomas,
> 
> On 10/29/24 02:24, Thomas Huth wrote:
>> Some of the URLs in the Avocado tests stopped working since the
>> original assets have been removed from the servers or moved location,
>> see:
>>
>>   https://lore.kernel.org/qemu-devel/CACPK8Xc=jsz5iT_WR7s- 
>> rcu1cRzryiK+-0o=6vUK_D_qMMrP3A@mail.gmail.com/
>>
>> Since we are currently in progress of converting the Avocado tests
>> to the new functional framework, this is a good opportunity to convert
>> these tests and adjust the URLs (and hashsums) along the way to make
>> these tests work again.
>>
>> Thomas Huth (2):
>>    tests/functional: Convert BananaPi tests to the functional framework
>>    tests/functional: Convert the OrangePi tests to the functional
>>      framework
>>
>>   MAINTAINERS                           |   1 +
>>   tests/avocado/boot_linux_console.py   | 411 --------------------------
>>   tests/functional/meson.build          |   4 +
>>   tests/functional/qemu_test/utils.py   |  21 ++
>>   tests/functional/test_arm_bpim2u.py   | 206 +++++++++++++
>>   tests/functional/test_arm_orangepi.py | 270 +++++++++++++++++
>>   6 files changed, 502 insertions(+), 411 deletions(-)
>>   create mode 100755 tests/functional/test_arm_bpim2u.py
>>   create mode 100755 tests/functional/test_arm_orangepi.py
>>
> 
> I have a general question regarding tests in QEMU.
> Is the current goal to convert all avocado tests to functional ones, and 
> then remove avocado from codebase?

Yes, I think that's the best way to move forward. It's weird to have two 
test runners in QEMU for the tests, and since we're already using the meson 
test runner for almost everything else, we should continue this transition.

  Thomas
Pierrick Bouvier Oct. 29, 2024, 4:54 p.m. UTC | #3
On 10/29/24 09:50, Thomas Huth wrote:
> On 29/10/2024 17.31, Pierrick Bouvier wrote:
>> Hi Thomas,
>>
>> On 10/29/24 02:24, Thomas Huth wrote:
>>> Some of the URLs in the Avocado tests stopped working since the
>>> original assets have been removed from the servers or moved location,
>>> see:
>>>
>>>    https://lore.kernel.org/qemu-devel/CACPK8Xc=jsz5iT_WR7s-
>>> rcu1cRzryiK+-0o=6vUK_D_qMMrP3A@mail.gmail.com/
>>>
>>> Since we are currently in progress of converting the Avocado tests
>>> to the new functional framework, this is a good opportunity to convert
>>> these tests and adjust the URLs (and hashsums) along the way to make
>>> these tests work again.
>>>
>>> Thomas Huth (2):
>>>     tests/functional: Convert BananaPi tests to the functional framework
>>>     tests/functional: Convert the OrangePi tests to the functional
>>>       framework
>>>
>>>    MAINTAINERS                           |   1 +
>>>    tests/avocado/boot_linux_console.py   | 411 --------------------------
>>>    tests/functional/meson.build          |   4 +
>>>    tests/functional/qemu_test/utils.py   |  21 ++
>>>    tests/functional/test_arm_bpim2u.py   | 206 +++++++++++++
>>>    tests/functional/test_arm_orangepi.py | 270 +++++++++++++++++
>>>    6 files changed, 502 insertions(+), 411 deletions(-)
>>>    create mode 100755 tests/functional/test_arm_bpim2u.py
>>>    create mode 100755 tests/functional/test_arm_orangepi.py
>>>
>>
>> I have a general question regarding tests in QEMU.
>> Is the current goal to convert all avocado tests to functional ones, and
>> then remove avocado from codebase?
> 
> Yes, I think that's the best way to move forward. It's weird to have two
> test runners in QEMU for the tests, and since we're already using the meson
> test runner for almost everything else, we should continue this transition.
> 

Sounds good. In my experience, it's a bit annoying to not be able to 
precache easily assets for avocado tests.

>    Thomas
>