| Message ID | 20241029191640.379315-1-festevam@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v3,1/3] dt-bindings: lcdif: Document a imx6sx-lcdif fallback | expand |
On Tue, 29 Oct 2024 16:16:38 -0300, Fabio Estevam wrote: > From: Fabio Estevam <festevam@denx.de> > > imx6sx.dtsi has the following lcdif entries: > > compatible = "fsl,imx6sx-lcdif", "fsl,imx28-lcdif"; > > This causes the following dt-schema warning: > > ['fsl,imx6sx-lcdif', 'fsl,imx28-lcdif'] is too long > > To keep DT compatibility, document 'fsl,imx28-lcdif' as a possible > 'fsl,imx6sx-lcdif' fallback. > > Signed-off-by: Fabio Estevam <festevam@denx.de> > --- > Changes since v2: > - Only document fsl,imx6sx-lcdif with a fallback. > > Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/fsl,lcdif.example.dtb: display-controller@2220000: compatible: 'oneOf' conditional failed, one must be fixed: ['fsl,imx6sx-lcdif'] is too short 'fsl,imx6sx-lcdif' is not one of ['fsl,imx23-lcdif', 'fsl,imx28-lcdif', 'fsl,imx8mp-lcdif', 'fsl,imx93-lcdif'] 'fsl,imx6sx-lcdif' is not one of ['fsl,imx6sl-lcdif', 'fsl,imx6sll-lcdif', 'fsl,imx6ul-lcdif', 'fsl,imx7d-lcdif', 'fsl,imx8mm-lcdif', 'fsl,imx8mn-lcdif', 'fsl,imx8mq-lcdif'] from schema $id: http://devicetree.org/schemas/display/fsl,lcdif.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241029191640.379315-1-festevam@gmail.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml index 8e3a98aeec32..ad0cca562463 100644 --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml @@ -19,7 +19,6 @@ properties: - enum: - fsl,imx23-lcdif - fsl,imx28-lcdif - - fsl,imx6sx-lcdif - fsl,imx8mp-lcdif - fsl,imx93-lcdif - items: @@ -32,6 +31,10 @@ properties: - fsl,imx8mn-lcdif - fsl,imx8mq-lcdif - const: fsl,imx6sx-lcdif + - items: + - enum: + - fsl,imx6sx-lcdif + - const: fsl,imx28-lcdif reg: maxItems: 1