| Message ID | 20241029111309.737263-1-wenst@chromium.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | drm/mediatek: Drop dependency on ARM | expand |
Hi, Chen-yu: On Tue, 2024-10-29 at 19:13 +0800, Chen-Yu Tsai wrote: > External email : Please do not click links or open attachments until you have verified the sender or the content. > > > The recent attempt to make the MediaTek DRM driver build for non-ARM > compile tests made the driver unbuildable for arm64 platforms. Since > this is used on both ARM and arm64 platforms, just drop the dependency > on ARM. Reviewed-by: CK Hu <ck.hu@mediatek.com> I find this days ago, but I don't know there is someone who apply it. Let this patch go through drm-misc tree which already has the bug patch. Regards, CK > > Fixes: d2db0b8fd70b ("drm/mediatek: Allow build with COMPILE_TEST=y") > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> > --- > It looks like the culprit commit was merged through the drm-misc tree. > So please merge this on top ASAP. > > drivers/gpu/drm/mediatek/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig > index 2e0e7c4079b6..f496e6cfdfe0 100644 > --- a/drivers/gpu/drm/mediatek/Kconfig > +++ b/drivers/gpu/drm/mediatek/Kconfig > @@ -2,7 +2,7 @@ > config DRM_MEDIATEK > tristate "DRM Support for Mediatek SoCs" > depends on DRM > - depends on (ARCH_MEDIATEK && ARM) || COMPILE_TEST > + depends on ARCH_MEDIATEK || COMPILE_TEST > depends on COMMON_CLK > depends on HAVE_ARM_SMCCC || COMPILE_TEST > depends on OF > -- > 2.47.0.163.g1226f6d8fa-goog >
On Wed, Oct 30, 2024 at 03:30:34AM +0000, CK Hu (胡俊光) wrote: > Hi, Chen-yu: > > On Tue, 2024-10-29 at 19:13 +0800, Chen-Yu Tsai wrote: > > External email : Please do not click links or open attachments until you have verified the sender or the content. > > > > > > The recent attempt to make the MediaTek DRM driver build for non-ARM > > compile tests made the driver unbuildable for arm64 platforms. Since > > this is used on both ARM and arm64 platforms, just drop the dependency > > on ARM. > > Reviewed-by: CK Hu <ck.hu@mediatek.com> > > I find this days ago, but I don't know there is someone who apply it. > Let this patch go through drm-misc tree which already has the bug patch. If you are ok with this patch, why didn't you apply it yourself? I think that's very much the expectation, so it's probably took a while to merge. Maxime
On Wed, 2024-10-30 at 09:25 +0100, mripard@kernel.org wrote: > On Wed, Oct 30, 2024 at 03:30:34AM +0000, CK Hu (胡俊光) wrote: > > Hi, Chen-yu: > > > > On Tue, 2024-10-29 at 19:13 +0800, Chen-Yu Tsai wrote: > > > External email : Please do not click links or open attachments until you have verified the sender or the content. > > > > > > > > > The recent attempt to make the MediaTek DRM driver build for non-ARM > > > compile tests made the driver unbuildable for arm64 platforms. Since > > > this is used on both ARM and arm64 platforms, just drop the dependency > > > on ARM. > > > > Reviewed-by: CK Hu <ck.hu@mediatek.com> > > > > I find this days ago, but I don't know there is someone who apply it. > > Let this patch go through drm-misc tree which already has the bug patch. > > If you are ok with this patch, why didn't you apply it yourself? > > I think that's very much the expectation, so it's probably took a while to merge. That's ok for me to apply it if drm-misc has no plan to apply it. Regards, CK > > Maxime
On Wed, Oct 30, 2024 at 4:48 PM CK Hu (胡俊光) <ck.hu@mediatek.com> wrote: > > On Wed, 2024-10-30 at 09:25 +0100, mripard@kernel.org wrote: > > On Wed, Oct 30, 2024 at 03:30:34AM +0000, CK Hu (胡俊光) wrote: > > > Hi, Chen-yu: > > > > > > On Tue, 2024-10-29 at 19:13 +0800, Chen-Yu Tsai wrote: > > > > External email : Please do not click links or open attachments until you have verified the sender or the content. > > > > > > > > > > > > The recent attempt to make the MediaTek DRM driver build for non-ARM > > > > compile tests made the driver unbuildable for arm64 platforms. Since > > > > this is used on both ARM and arm64 platforms, just drop the dependency > > > > on ARM. > > > > > > Reviewed-by: CK Hu <ck.hu@mediatek.com> > > > > > > I find this days ago, but I don't know there is someone who apply it. > > > Let this patch go through drm-misc tree which already has the bug patch. > > > > If you are ok with this patch, why didn't you apply it yourself? > > > > I think that's very much the expectation, so it's probably took a while to merge. > > That's ok for me to apply it if drm-misc has no plan to apply it. I'm confused. The culprit patch is already in drm-misc. So this one has to go in drm-misc as well. I can try to apply it to drm-misc myself, or have a colleague assist with that. I'll let it sit for another day in case anyone has something to say about it. ChenYu
On Wed, Oct 30, 2024 at 04:52:17PM +0800, Chen-Yu Tsai wrote: > On Wed, Oct 30, 2024 at 4:48 PM CK Hu (胡俊光) <ck.hu@mediatek.com> wrote: > > > > On Wed, 2024-10-30 at 09:25 +0100, mripard@kernel.org wrote: > > > On Wed, Oct 30, 2024 at 03:30:34AM +0000, CK Hu (胡俊光) wrote: > > > > Hi, Chen-yu: > > > > > > > > On Tue, 2024-10-29 at 19:13 +0800, Chen-Yu Tsai wrote: > > > > > External email : Please do not click links or open attachments until you have verified the sender or the content. > > > > > > > > > > > > > > > The recent attempt to make the MediaTek DRM driver build for non-ARM > > > > > compile tests made the driver unbuildable for arm64 platforms. Since > > > > > this is used on both ARM and arm64 platforms, just drop the dependency > > > > > on ARM. > > > > > > > > Reviewed-by: CK Hu <ck.hu@mediatek.com> > > > > > > > > I find this days ago, but I don't know there is someone who apply it. > > > > Let this patch go through drm-misc tree which already has the bug patch. > > > > > > If you are ok with this patch, why didn't you apply it yourself? > > > > > > I think that's very much the expectation, so it's probably took a while to merge. > > > > That's ok for me to apply it if drm-misc has no plan to apply it. > > I'm confused. The culprit patch is already in drm-misc. So this one has > to go in drm-misc as well. > > I can try to apply it to drm-misc myself, or have a colleague assist with > that. I'll let it sit for another day in case anyone has something to say > about it. Sorry, I was under the assumption that CK had drm-misc commit rights? It should go through drm-misc indeed. Maxime
On Thu, Oct 31, 2024 at 5:30 PM mripard@kernel.org <mripard@kernel.org> wrote: > > On Wed, Oct 30, 2024 at 04:52:17PM +0800, Chen-Yu Tsai wrote: > > On Wed, Oct 30, 2024 at 4:48 PM CK Hu (胡俊光) <ck.hu@mediatek.com> wrote: > > > > > > On Wed, 2024-10-30 at 09:25 +0100, mripard@kernel.org wrote: > > > > On Wed, Oct 30, 2024 at 03:30:34AM +0000, CK Hu (胡俊光) wrote: > > > > > Hi, Chen-yu: > > > > > > > > > > On Tue, 2024-10-29 at 19:13 +0800, Chen-Yu Tsai wrote: > > > > > > External email : Please do not click links or open attachments until you have verified the sender or the content. > > > > > > > > > > > > > > > > > > The recent attempt to make the MediaTek DRM driver build for non-ARM > > > > > > compile tests made the driver unbuildable for arm64 platforms. Since > > > > > > this is used on both ARM and arm64 platforms, just drop the dependency > > > > > > on ARM. > > > > > > > > > > Reviewed-by: CK Hu <ck.hu@mediatek.com> > > > > > > > > > > I find this days ago, but I don't know there is someone who apply it. > > > > > Let this patch go through drm-misc tree which already has the bug patch. > > > > > > > > If you are ok with this patch, why didn't you apply it yourself? > > > > > > > > I think that's very much the expectation, so it's probably took a while to merge. > > > > > > That's ok for me to apply it if drm-misc has no plan to apply it. > > > > I'm confused. The culprit patch is already in drm-misc. So this one has > > to go in drm-misc as well. > > > > I can try to apply it to drm-misc myself, or have a colleague assist with > > that. I'll let it sit for another day in case anyone has something to say > > about it. > > Sorry, I was under the assumption that CK had drm-misc commit rights? It > should go through drm-misc indeed. CK has always maintained a separate tree on git.kernel.org, so I don't know if drm-misc commit rights were ever granted? ChenYu
diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig index 2e0e7c4079b6..f496e6cfdfe0 100644 --- a/drivers/gpu/drm/mediatek/Kconfig +++ b/drivers/gpu/drm/mediatek/Kconfig @@ -2,7 +2,7 @@ config DRM_MEDIATEK tristate "DRM Support for Mediatek SoCs" depends on DRM - depends on (ARCH_MEDIATEK && ARM) || COMPILE_TEST + depends on ARCH_MEDIATEK || COMPILE_TEST depends on COMMON_CLK depends on HAVE_ARM_SMCCC || COMPILE_TEST depends on OF
The recent attempt to make the MediaTek DRM driver build for non-ARM compile tests made the driver unbuildable for arm64 platforms. Since this is used on both ARM and arm64 platforms, just drop the dependency on ARM. Fixes: d2db0b8fd70b ("drm/mediatek: Allow build with COMPILE_TEST=y") Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> --- It looks like the culprit commit was merged through the drm-misc tree. So please merge this on top ASAP. drivers/gpu/drm/mediatek/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)