| Message ID | 20241030015326.2289070-1-benchuanggli@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | mmc: sdhci-uhs2: Remove unnecessary NULL check | expand |
On 30/10/24 03:53, Ben Chuang wrote: > From: Ben Chuang <ben.chuang@genesyslogic.com.tw> > > The "host->ops" pointer points to an offset into the "sdhci_ops" struct > so it cannot be NULL. Remove "host->ops" check in "if" statement. It is a pointer, so it could be NULL, but it never will be in this function. > > Reported-by: Dan Carpenter <dan.carpenter@linaro.org> > Closes: https://lore.kernel.org/r/202410271835.tqz9s9JV-lkp@intel.com/ > Signed-off-by: Ben Chuang <ben.chuang@genesyslogic.com.tw> Apart from commit message: Acked-by: Adrian Hunter <adrian.hunter@intel.com> > --- > drivers/mmc/host/sdhci-uhs2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci-uhs2.c b/drivers/mmc/host/sdhci-uhs2.c > index c488c6d56015..b0e4ab852a94 100644 > --- a/drivers/mmc/host/sdhci-uhs2.c > +++ b/drivers/mmc/host/sdhci-uhs2.c > @@ -413,7 +413,7 @@ static int sdhci_uhs2_do_detect_init(struct mmc_host *mmc) > > DBG("Begin do uhs2 detect init.\n"); > > - if (host->ops && host->ops->uhs2_pre_detect_init) > + if (host->ops->uhs2_pre_detect_init) > host->ops->uhs2_pre_detect_init(host); > > if (sdhci_uhs2_interface_detect(host)) {
On Wed, 30 Oct 2024 at 02:54, Ben Chuang <benchuanggli@gmail.com> wrote: > > From: Ben Chuang <ben.chuang@genesyslogic.com.tw> > > The "host->ops" pointer points to an offset into the "sdhci_ops" struct > so it cannot be NULL. Remove "host->ops" check in "if" statement. > > Reported-by: Dan Carpenter <dan.carpenter@linaro.org> > Closes: https://lore.kernel.org/r/202410271835.tqz9s9JV-lkp@intel.com/ > Signed-off-by: Ben Chuang <ben.chuang@genesyslogic.com.tw> Applied for next and by amending the commit message a bit, thanks! Kind regards Uffe > --- > drivers/mmc/host/sdhci-uhs2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci-uhs2.c b/drivers/mmc/host/sdhci-uhs2.c > index c488c6d56015..b0e4ab852a94 100644 > --- a/drivers/mmc/host/sdhci-uhs2.c > +++ b/drivers/mmc/host/sdhci-uhs2.c > @@ -413,7 +413,7 @@ static int sdhci_uhs2_do_detect_init(struct mmc_host *mmc) > > DBG("Begin do uhs2 detect init.\n"); > > - if (host->ops && host->ops->uhs2_pre_detect_init) > + if (host->ops->uhs2_pre_detect_init) > host->ops->uhs2_pre_detect_init(host); > > if (sdhci_uhs2_interface_detect(host)) { > -- > 2.47.0 >
diff --git a/drivers/mmc/host/sdhci-uhs2.c b/drivers/mmc/host/sdhci-uhs2.c index c488c6d56015..b0e4ab852a94 100644 --- a/drivers/mmc/host/sdhci-uhs2.c +++ b/drivers/mmc/host/sdhci-uhs2.c @@ -413,7 +413,7 @@ static int sdhci_uhs2_do_detect_init(struct mmc_host *mmc) DBG("Begin do uhs2 detect init.\n"); - if (host->ops && host->ops->uhs2_pre_detect_init) + if (host->ops->uhs2_pre_detect_init) host->ops->uhs2_pre_detect_init(host); if (sdhci_uhs2_interface_detect(host)) {