| Message ID | 20241029-v3d-v2-1-c0d3dd328d1b@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] drm/v3d: Drop allocation of object without mountpoint | expand |
Hi Matthias, On 29/10/24 08:24, matthias.bgg@kernel.org wrote: > From: Matthias Brugger <matthias.bgg@gmail.com> > > Function drm_gem_shmem_create_with_mnt() creates an object > without using the mountpoint if gemfs is NULL. > > Drop the else branch calling drm_gem_shmem_create(). > > Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com> Applied to misc/kernel.git (drm-misc-next). Best Regards, - Maíra > --- > Changes in v2: > - Fix indentation > - Link to v1: https://lore.kernel.org/r/20241028-v3d-v1-1-907bee355edf@gmail.com > --- > drivers/gpu/drm/v3d/v3d_bo.c | 9 ++------- > 1 file changed, 2 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/v3d/v3d_bo.c b/drivers/gpu/drm/v3d/v3d_bo.c > index 7055f7c7bcfe5700aee10b09ecc0005197323b01..73ab7dd31b17b249b7688dcc9833fd161211b6d9 100644 > --- a/drivers/gpu/drm/v3d/v3d_bo.c > +++ b/drivers/gpu/drm/v3d/v3d_bo.c > @@ -157,13 +157,8 @@ struct v3d_bo *v3d_bo_create(struct drm_device *dev, struct drm_file *file_priv, > struct v3d_bo *bo; > int ret; > > - /* Let the user opt out of allocating the BOs with THP */ > - if (v3d->gemfs) > - shmem_obj = drm_gem_shmem_create_with_mnt(dev, unaligned_size, > - v3d->gemfs); > - else > - shmem_obj = drm_gem_shmem_create(dev, unaligned_size); > - > + shmem_obj = drm_gem_shmem_create_with_mnt(dev, unaligned_size, > + v3d->gemfs); > if (IS_ERR(shmem_obj)) > return ERR_CAST(shmem_obj); > bo = to_v3d_bo(&shmem_obj->base); > > --- > base-commit: dec9255a128e19c5fcc3bdb18175d78094cc624d > change-id: 20241028-v3d-1d2546ed92d7 > > Best regards,
diff --git a/drivers/gpu/drm/v3d/v3d_bo.c b/drivers/gpu/drm/v3d/v3d_bo.c index 7055f7c7bcfe5700aee10b09ecc0005197323b01..73ab7dd31b17b249b7688dcc9833fd161211b6d9 100644 --- a/drivers/gpu/drm/v3d/v3d_bo.c +++ b/drivers/gpu/drm/v3d/v3d_bo.c @@ -157,13 +157,8 @@ struct v3d_bo *v3d_bo_create(struct drm_device *dev, struct drm_file *file_priv, struct v3d_bo *bo; int ret; - /* Let the user opt out of allocating the BOs with THP */ - if (v3d->gemfs) - shmem_obj = drm_gem_shmem_create_with_mnt(dev, unaligned_size, - v3d->gemfs); - else - shmem_obj = drm_gem_shmem_create(dev, unaligned_size); - + shmem_obj = drm_gem_shmem_create_with_mnt(dev, unaligned_size, + v3d->gemfs); if (IS_ERR(shmem_obj)) return ERR_CAST(shmem_obj); bo = to_v3d_bo(&shmem_obj->base);