| Message ID | 20241029164317.50182-1-vladimir.oltean@nxp.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Fix sparse warnings in dpaa_eth driver | expand |
> -----Original Message----- > From: Vladimir Oltean <vladimir.oltean@nxp.com> > Sent: Tuesday, October 29, 2024 6:43 PM > To: netdev@vger.kernel.org > Cc: David S. Miller <davem@davemloft.net>; Eric Dumazet > <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni > <pabeni@redhat.com>; Breno Leitao <leitao@debian.org>; Madalin Bucur > <madalin.bucur@nxp.com>; Ioana Ciornei <ioana.ciornei@nxp.com>; Radu- > Andrei Bulie <radu-andrei.bulie@nxp.com>; Christophe Leroy > <christophe.leroy@csgroup.eu>; Sean Anderson <sean.anderson@linux.dev>; > linux-kernel@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; linux-arm- > kernel@lists.infradead.org > Subject: [PATCH net-next 0/3] Fix sparse warnings in dpaa_eth driver > > This is a follow-up of the discussion at: > https://lore.kernel.org/oe-kbuild-all/20241028-sticky-refined-lionfish- > b06c0c@leitao/ > where I said I would take care of the sparse warnings uncovered by > Breno's COMPILE_TEST change for the dpaa_eth driver. > > There was one warning that I decided to treat as an actual bug: > https://lore.kernel.org/netdev/20241029163105.44135-1- > vladimir.oltean@nxp.com/ > and what remains here are those warnings which I consider harmless. > > I would like Christophe to ack the entire series to be taken through > netdev. I find it weird that the qbman driver, whose major API consumer > is netdev, is maintained by a different group. In this case, the buggy > qm_sg_entry_get_off() function is defined in qbman but exclusively > called in netdev. > > Vladimir Oltean (3): > soc: fsl_qbman: use be16_to_cpu() in qm_sg_entry_get_off() > net: dpaa_eth: add assertions about SGT entry offsets in > sg_fd_to_skb() > net: dpaa_eth: extract hash using __be32 pointer in rx_default_dqrr() > > .../net/ethernet/freescale/dpaa/dpaa_eth.c | 26 ++++++++++++------- > include/soc/fsl/qman.h | 2 +- > 2 files changed, 17 insertions(+), 11 deletions(-) > > -- > 2.34.1 For the series, Acked-by: Madalin Bucur <madalin.bucur@oss.nxp.com> Thank you!
This is a follow-up of the discussion at: https://lore.kernel.org/oe-kbuild-all/20241028-sticky-refined-lionfish-b06c0c@leitao/ where I said I would take care of the sparse warnings uncovered by Breno's COMPILE_TEST change for the dpaa_eth driver. There was one warning that I decided to treat as an actual bug: https://lore.kernel.org/netdev/20241029163105.44135-1-vladimir.oltean@nxp.com/ and what remains here are those warnings which I consider harmless. I would like Christophe to ack the entire series to be taken through netdev. I find it weird that the qbman driver, whose major API consumer is netdev, is maintained by a different group. In this case, the buggy qm_sg_entry_get_off() function is defined in qbman but exclusively called in netdev. Vladimir Oltean (3): soc: fsl_qbman: use be16_to_cpu() in qm_sg_entry_get_off() net: dpaa_eth: add assertions about SGT entry offsets in sg_fd_to_skb() net: dpaa_eth: extract hash using __be32 pointer in rx_default_dqrr() .../net/ethernet/freescale/dpaa/dpaa_eth.c | 26 ++++++++++++------- include/soc/fsl/qman.h | 2 +- 2 files changed, 17 insertions(+), 11 deletions(-)