diff mbox series

[v1,1/1] s390/kvm: initialize uninitialized flags variable

Message ID 20241030161906.85476-1-imbrenda@linux.ibm.com (mailing list archive)
State New
Headers show
Series [v1,1/1] s390/kvm: initialize uninitialized flags variable | expand

Commit Message

Claudio Imbrenda Oct. 30, 2024, 4:19 p.m. UTC 
The flags variable was being used uninitialized.
Initialize it to 0 as expected.

For some reason neither gcc nor clang reported a warning.

Fixes: ce2b276ebe51 ("s390/mm/fault: Handle guest-related program interrupts in KVM")
Reported-by: Janosch Frank <frankja@linux.ibm.com>
Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
---
 arch/s390/kvm/kvm-s390.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Heiko Carstens Oct. 30, 2024, 5:04 p.m. UTC | #1 
On Wed, Oct 30, 2024 at 05:19:06PM +0100, Claudio Imbrenda wrote:
> The flags variable was being used uninitialized.
> Initialize it to 0 as expected.
> 
> For some reason neither gcc nor clang reported a warning.
> 
> Fixes: ce2b276ebe51 ("s390/mm/fault: Handle guest-related program interrupts in KVM")
> Reported-by: Janosch Frank <frankja@linux.ibm.com>
> Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
> ---
>  arch/s390/kvm/kvm-s390.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks!
diff mbox series

Patch

diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
index a5750c14bb4d..8b3afda99397 100644
--- a/arch/s390/kvm/kvm-s390.c
+++ b/arch/s390/kvm/kvm-s390.c
@@ -4729,8 +4729,8 @@  static int vcpu_post_run_addressing_exception(struct kvm_vcpu *vcpu)
 
 static int vcpu_post_run_handle_fault(struct kvm_vcpu *vcpu)
 {
+	unsigned int flags = 0;
 	unsigned long gaddr;
-	unsigned int flags;
 	int rc = 0;
 
 	gaddr = current->thread.gmap_teid.addr * PAGE_SIZE;