Message ID | 20241030180112.4635-10-joshi.k@samsung.com (mailing list archive) |
---|---|
State | New |
Headers | show |
Series | [v6,01/10] block: define set of integrity flags to be inherited by cloned bip | expand |
Hi Kanchan,
kernel test robot noticed the following build errors:
[auto build test ERROR on axboe-block/for-next]
[cannot apply to brauner-vfs/vfs.all mkp-scsi/for-next jejb-scsi/for-next linus/master v6.12-rc5 next-20241030]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Kanchan-Joshi/block-define-set-of-integrity-flags-to-be-inherited-by-cloned-bip/20241031-021248
base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
patch link: https://lore.kernel.org/r/20241030180112.4635-10-joshi.k%40samsung.com
patch subject: [PATCH v6 09/10] scsi: add support for user-meta interface
config: arm-randconfig-001-20241031 (https://download.01.org/0day-ci/archive/20241031/202410311216.YfNcxbSF-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241031/202410311216.YfNcxbSF-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410311216.YfNcxbSF-lkp@intel.com/
All errors (new ones prefixed by >>):
>> block/bio-integrity.c:566:40: error: use of undeclared identifier 'BIP_CTRL_NOCHECK'; did you mean 'BIP_DISK_NOCHECK'?
566 | bip->bip_flags = bip_src->bip_flags & BIP_CLONE_FLAGS;
| ^
include/linux/bio-integrity.h:35:49: note: expanded from macro 'BIP_CLONE_FLAGS'
35 | #define BIP_CLONE_FLAGS (BIP_MAPPED_INTEGRITY | BIP_CTRL_NOCHECK | \
| ^
include/linux/bio-integrity.h:10:2: note: 'BIP_DISK_NOCHECK' declared here
10 | BIP_DISK_NOCHECK = 1 << 2, /* disable disk integrity checking */
| ^
1 error generated.
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for GET_FREE_REGION
Depends on [n]: SPARSEMEM [=n]
Selected by [y]:
- RESOURCE_KUNIT_TEST [=y] && RUNTIME_TESTING_MENU [=y] && KUNIT [=y]
vim +566 block/bio-integrity.c
7ba1ba12eeef0aa fs/bio-integrity.c Martin K. Petersen 2008-06-30 543
7ba1ba12eeef0aa fs/bio-integrity.c Martin K. Petersen 2008-06-30 544 /**
7ba1ba12eeef0aa fs/bio-integrity.c Martin K. Petersen 2008-06-30 545 * bio_integrity_clone - Callback for cloning bios with integrity metadata
7ba1ba12eeef0aa fs/bio-integrity.c Martin K. Petersen 2008-06-30 546 * @bio: New bio
7ba1ba12eeef0aa fs/bio-integrity.c Martin K. Petersen 2008-06-30 547 * @bio_src: Original bio
87092698c665e0a fs/bio-integrity.c un'ichi Nomura 2009-03-09 548 * @gfp_mask: Memory allocation mask
7ba1ba12eeef0aa fs/bio-integrity.c Martin K. Petersen 2008-06-30 549 *
7ba1ba12eeef0aa fs/bio-integrity.c Martin K. Petersen 2008-06-30 550 * Description: Called to allocate a bip when cloning a bio
7ba1ba12eeef0aa fs/bio-integrity.c Martin K. Petersen 2008-06-30 551 */
7878cba9f0037f5 fs/bio-integrity.c Martin K. Petersen 2009-06-26 552 int bio_integrity_clone(struct bio *bio, struct bio *bio_src,
1e2a410ff71504a fs/bio-integrity.c Kent Overstreet 2012-09-06 553 gfp_t gfp_mask)
7ba1ba12eeef0aa fs/bio-integrity.c Martin K. Petersen 2008-06-30 554 {
180b2f95dd33101 block/bio-integrity.c Martin K. Petersen 2014-09-26 555 struct bio_integrity_payload *bip_src = bio_integrity(bio_src);
7ba1ba12eeef0aa fs/bio-integrity.c Martin K. Petersen 2008-06-30 556 struct bio_integrity_payload *bip;
7ba1ba12eeef0aa fs/bio-integrity.c Martin K. Petersen 2008-06-30 557
7ba1ba12eeef0aa fs/bio-integrity.c Martin K. Petersen 2008-06-30 558 BUG_ON(bip_src == NULL);
7ba1ba12eeef0aa fs/bio-integrity.c Martin K. Petersen 2008-06-30 559
ba942238056584e block/bio-integrity.c Anuj Gupta 2024-07-02 560 bip = bio_integrity_alloc(bio, gfp_mask, 0);
7b6c0f8034d7839 block/bio-integrity.c Dan Carpenter 2015-12-09 561 if (IS_ERR(bip))
7b6c0f8034d7839 block/bio-integrity.c Dan Carpenter 2015-12-09 562 return PTR_ERR(bip);
7ba1ba12eeef0aa fs/bio-integrity.c Martin K. Petersen 2008-06-30 563
ba942238056584e block/bio-integrity.c Anuj Gupta 2024-07-02 564 bip->bip_vec = bip_src->bip_vec;
d57a5f7c6605f15 fs/bio-integrity.c Kent Overstreet 2013-11-23 565 bip->bip_iter = bip_src->bip_iter;
be32c1180d327a0 block/bio-integrity.c Anuj Gupta 2024-10-30 @566 bip->bip_flags = bip_src->bip_flags & BIP_CLONE_FLAGS;
7ba1ba12eeef0aa fs/bio-integrity.c Martin K. Petersen 2008-06-30 567
7ba1ba12eeef0aa fs/bio-integrity.c Martin K. Petersen 2008-06-30 568 return 0;
7ba1ba12eeef0aa fs/bio-integrity.c Martin K. Petersen 2008-06-30 569 }
7ba1ba12eeef0aa fs/bio-integrity.c Martin K. Petersen 2008-06-30 570
Hi Kanchan,
kernel test robot noticed the following build errors:
[auto build test ERROR on axboe-block/for-next]
[cannot apply to brauner-vfs/vfs.all mkp-scsi/for-next jejb-scsi/for-next linus/master v6.12-rc5 next-20241030]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Kanchan-Joshi/block-define-set-of-integrity-flags-to-be-inherited-by-cloned-bip/20241031-021248
base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
patch link: https://lore.kernel.org/r/20241030180112.4635-10-joshi.k%40samsung.com
patch subject: [PATCH v6 09/10] scsi: add support for user-meta interface
config: x86_64-rhel-8.3 (https://download.01.org/0day-ci/archive/20241031/202410311347.qYRyUdmR-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241031/202410311347.qYRyUdmR-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410311347.qYRyUdmR-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from include/linux/blk-integrity.h:6,
from block/bio-integrity.c:9:
block/bio-integrity.c: In function 'bio_integrity_clone':
>> include/linux/bio-integrity.h:35:49: error: 'BIP_CTRL_NOCHECK' undeclared (first use in this function); did you mean 'BIP_DISK_NOCHECK'?
35 | #define BIP_CLONE_FLAGS (BIP_MAPPED_INTEGRITY | BIP_CTRL_NOCHECK | \
| ^~~~~~~~~~~~~~~~
block/bio-integrity.c:566:47: note: in expansion of macro 'BIP_CLONE_FLAGS'
566 | bip->bip_flags = bip_src->bip_flags & BIP_CLONE_FLAGS;
| ^~~~~~~~~~~~~~~
include/linux/bio-integrity.h:35:49: note: each undeclared identifier is reported only once for each function it appears in
35 | #define BIP_CLONE_FLAGS (BIP_MAPPED_INTEGRITY | BIP_CTRL_NOCHECK | \
| ^~~~~~~~~~~~~~~~
block/bio-integrity.c:566:47: note: in expansion of macro 'BIP_CLONE_FLAGS'
566 | bip->bip_flags = bip_src->bip_flags & BIP_CLONE_FLAGS;
| ^~~~~~~~~~~~~~~
vim +35 include/linux/bio-integrity.h
da042a365515115 Christoph Hellwig 2024-07-02 34
be32c1180d327a0 Anuj Gupta 2024-10-30 @35 #define BIP_CLONE_FLAGS (BIP_MAPPED_INTEGRITY | BIP_CTRL_NOCHECK | \
ed538815d9325f6 Anuj Gupta 2024-10-30 36 BIP_IP_CHECKSUM | BIP_CHECK_GUARD | \
ed538815d9325f6 Anuj Gupta 2024-10-30 37 BIP_CHECK_REFTAG | BIP_CHECK_APPTAG)
be32c1180d327a0 Anuj Gupta 2024-10-30 38
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index ca4bc0ac76ad..d1a2ae0d4c29 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -814,14 +814,14 @@ static unsigned char sd_setup_protect_cmnd(struct scsi_cmnd *scmd, if (bio_integrity_flagged(bio, BIP_IP_CHECKSUM)) scmd->prot_flags |= SCSI_PROT_IP_CHECKSUM; - if (bio_integrity_flagged(bio, BIP_CTRL_NOCHECK) == false) + if (bio_integrity_flagged(bio, BIP_CHECK_GUARD)) scmd->prot_flags |= SCSI_PROT_GUARD_CHECK; } if (dif != T10_PI_TYPE3_PROTECTION) { /* DIX/DIF Type 0, 1, 2 */ scmd->prot_flags |= SCSI_PROT_REF_INCREMENT; - if (bio_integrity_flagged(bio, BIP_CTRL_NOCHECK) == false) + if (bio_integrity_flagged(bio, BIP_CHECK_REFTAG)) scmd->prot_flags |= SCSI_PROT_REF_CHECK; } diff --git a/include/linux/bio-integrity.h b/include/linux/bio-integrity.h index fe2bfe122db2..0046c744ea53 100644 --- a/include/linux/bio-integrity.h +++ b/include/linux/bio-integrity.h @@ -7,13 +7,12 @@ enum bip_flags { BIP_BLOCK_INTEGRITY = 1 << 0, /* block layer owns integrity data */ BIP_MAPPED_INTEGRITY = 1 << 1, /* ref tag has been remapped */ - BIP_CTRL_NOCHECK = 1 << 2, /* disable HBA integrity checking */ - BIP_DISK_NOCHECK = 1 << 3, /* disable disk integrity checking */ - BIP_IP_CHECKSUM = 1 << 4, /* IP checksum */ - BIP_COPY_USER = 1 << 5, /* Kernel bounce buffer in use */ - BIP_CHECK_GUARD = 1 << 6, /* guard check */ - BIP_CHECK_REFTAG = 1 << 7, /* reftag check */ - BIP_CHECK_APPTAG = 1 << 8, /* apptag check */ + BIP_DISK_NOCHECK = 1 << 2, /* disable disk integrity checking */ + BIP_IP_CHECKSUM = 1 << 3, /* IP checksum */ + BIP_COPY_USER = 1 << 4, /* Kernel bounce buffer in use */ + BIP_CHECK_GUARD = 1 << 5, /* guard check */ + BIP_CHECK_REFTAG = 1 << 6, /* reftag check */ + BIP_CHECK_APPTAG = 1 << 7, /* apptag check */ }; struct bio_integrity_payload { @@ -34,8 +33,8 @@ struct bio_integrity_payload { }; #define BIP_CLONE_FLAGS (BIP_MAPPED_INTEGRITY | BIP_CTRL_NOCHECK | \ - BIP_DISK_NOCHECK | BIP_IP_CHECKSUM | \ - BIP_CHECK_GUARD | BIP_CHECK_REFTAG | BIP_CHECK_APPTAG) + BIP_IP_CHECKSUM | BIP_CHECK_GUARD | \ + BIP_CHECK_REFTAG | BIP_CHECK_APPTAG) #ifdef CONFIG_BLK_DEV_INTEGRITY