[v3,0/6] i2c: nomadik: support >=1MHz & Mobileye EyeQ6H platform

Message

Théo Lebrun Oct. 9, 2024, 2:01 p.m. UTC

Hi,

Three patches are about adding Mobileye EyeQ6H support to the Nomadik
I2C controller driver, in the same vein as was done a few months ago
for EyeQ5.
 - dt-bindings:
    - [PATCH 1/6]: add new compatible.
 - driver:
    - [PATCH 3/6]: we switch from using a match table, before adding the
      new EyeQ6H compatible.
    - [PATCH 4/6]: adding EyeQ6H is only about creating a new match
      table entry thanks to the previous patch; we reuse
      the .has_32b_bus flag created for EyeQ5.

Three patches are about supporting higher speeds (fast-plus and
high-speed).
 - dt-bindings:
    - [PATCH 2/6]: fix them, they indicated only a max of 400kHz.
 - driver:
    - [PATCH 5/6]: fix computation of the bus rate clock divider (BRCR).
      For a bus rate of 400kHz, it would pick >400kHz. Now pick <400kHz.
    - [PATCH 6/6]: support high SM (speed-mode) values.
      This is not much work.

It works on EyeQ6H HW just fine. 1MHz has been tested but not 3.4MHz
because HW doesn't support it. The theory is there, and BRCR
computation has been checked to be valid with 3.4MHz clocks.

DTS patches targeting EyeQ5 & EyeQ6H devicetrees are not provided
because they depend on the platform's clock series [0].

Have a nice day,
Théo

[0]: https://lore.kernel.org/lkml/[e-mail]/

Signed-off-by: Théo Lebrun <[e-mail]>
---
Changes in v3:
- [PATCH 5/6] "i2c: nomadik: fix BRCR computation":
  - Use DIV_ROUND_UP() for BRCR calculation.
  - Improve code comment.
  - Add small note in commit message about DIV_ROUND_UP() usage.
- For all patches but [PATCH 5/6], apply Reviewed-by: Linus Walleij.
- Link to v2: https://lore.kernel.org/r/[e-mail]

Changes in v2:
- dt-bindings: change `clock-frequency: maximum` from 400kHz to 3.4MHz
  in a separate patch.
- dt-bindings: use enum to list compatibles.
- Switch away from of_device_is_compatible() in probe. Use a match table
  with flags inside .data, using of_match_device() from probe.
  This is done as a separate commit before adding EyeQ6H support.
- Link to v1: https://lore.kernel.org/r/[e-mail]

---
Théo Lebrun (6):
      dt-bindings: i2c: nomadik: add mobileye,eyeq6h-i2c bindings
      dt-bindings: i2c: nomadik: support 400kHz < clock-frequency <= 3.4MHz
      i2c: nomadik: switch from of_device_is_compatible() to of_match_device()
      i2c: nomadik: support Mobileye EyeQ6H I2C controller
      i2c: nomadik: fix BRCR computation
      i2c: nomadik: support >=1MHz speed modes

 .../devicetree/bindings/i2c/st,nomadik-i2c.yaml    | 13 ++--
 drivers/i2c/busses/i2c-nomadik.c                   | 89 +++++++++++++---------
 2 files changed, 61 insertions(+), 41 deletions(-)
---
base-commit: 6f1cfa7816af8b3286140f1b0476200d5e914eb9
change-id: 20241007-mbly-i2c-267c9d482b90

Best regards,

Comments

Théo Lebrun Oct. 31, 2024, 4:14 p.m. UTC | #1

Hi Andi,

On Wed Oct 9, 2024 at 4:01 PM CEST, Théo Lebrun wrote:
> Three patches are about adding Mobileye EyeQ6H support to the Nomadik
> I2C controller driver, in the same vein as was done a few months ago
> for EyeQ5.
[...]
> Three patches are about supporting higher speeds (fast-plus and
> high-speed).

I come in checking. What's your state of mind about that series?

Rob has given his Reviewed-By on both dt-bindings patches, and Linus
gave his on all patches. I can send a new revision taking the three
Reviewed-By trailers from this V3 if you like.

Also, i2c-host-next is free of conflicts on Nomadik files.

Thanks!

--
Théo Lebrun, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com