mbox series

[v1,0/2] iio: adc: Check for error from devm_mutex_init()

Message ID 20241030162013.2100253-1-andriy.shevchenko@linux.intel.com (mailing list archive)
Headers show
Series iio: adc: Check for error from devm_mutex_init() | expand

Message

Andy Shevchenko Oct. 30, 2024, 4:19 p.m. UTC 
Ignoring error checking from devm calls is a bad practice in general.
While not critical today, it may become a problem tomorrow.
Fix this for devm_mutex_init().

Andy Shevchenko (2):
  iio: adc: ad4000: Check for error code from devm_mutex_init() call
  iio: adc: pac1921: Check for error code from devm_mutex_init() call

 drivers/iio/adc/ad4000.c  | 4 +++-
 drivers/iio/adc/pac1921.c | 4 +++-
 2 files changed, 6 insertions(+), 2 deletions(-)

Comments

Jonathan Cameron Oct. 31, 2024, 7:19 p.m. UTC | #1 
On Wed, 30 Oct 2024 18:19:17 +0200
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> Ignoring error checking from devm calls is a bad practice in general.
> While not critical today, it may become a problem tomorrow.
> Fix this for devm_mutex_init().
> 
> Andy Shevchenko (2):
>   iio: adc: ad4000: Check for error code from devm_mutex_init() call
>   iio: adc: pac1921: Check for error code from devm_mutex_init() call
> 
Oops. Missed this in review obviously.

Applied.
>  drivers/iio/adc/ad4000.c  | 4 +++-
>  drivers/iio/adc/pac1921.c | 4 +++-
>  2 files changed, 6 insertions(+), 2 deletions(-)
>