| Message ID | 20241031095339.76535-1-jiapeng.chong@linux.alibaba.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v3,-next] i2c: qcom-cci: Remove the unused variable cci_clk_rate | expand |
On Thu, Oct 31, 2024 at 05:53:39PM +0800, Jiapeng Chong wrote: > Variable cci_clk_rate is not effectively used, so delete it. > > drivers/i2c/busses/i2c-qcom-cci.c:526:16: warning: variable ‘cci_clk_rate’ set but not used. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11532 > Fixes: 823dfb7bdb21 ("i2c: qcom-cci: Stop complaining about DT set clock rate") > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > --- > Changes in v3: > -Modify the commit message. Modify how? What was the reason for ignoring the R-B tag? > > drivers/i2c/busses/i2c-qcom-cci.c | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-qcom-cci.c b/drivers/i2c/busses/i2c-qcom-cci.c > index 5cc791b3b57d..a0ef43e99751 100644 > --- a/drivers/i2c/busses/i2c-qcom-cci.c > +++ b/drivers/i2c/busses/i2c-qcom-cci.c > @@ -523,7 +523,6 @@ static const struct dev_pm_ops qcom_cci_pm = { > static int cci_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > - unsigned long cci_clk_rate = 0; > struct device_node *child; > struct resource *r; > struct cci *cci; > @@ -594,14 +593,6 @@ static int cci_probe(struct platform_device *pdev) > return dev_err_probe(dev, -EINVAL, "not enough clocks in DT\n"); > cci->nclocks = ret; > > - /* Retrieve CCI clock rate */ > - for (i = 0; i < cci->nclocks; i++) { > - if (!strcmp(cci->clocks[i].id, "cci")) { > - cci_clk_rate = clk_get_rate(cci->clocks[i].clk); > - break; > - } > - } > - > ret = cci_enable_clocks(cci); > if (ret < 0) > return ret; > -- > 2.32.0.3.g01195cf9f >
Hi Dmitry, On Thu, Oct 31, 2024 at 06:51:13PM +0200, Dmitry Baryshkov wrote: > On Thu, Oct 31, 2024 at 05:53:39PM +0800, Jiapeng Chong wrote: > > Variable cci_clk_rate is not effectively used, so delete it. > > > > drivers/i2c/busses/i2c-qcom-cci.c:526:16: warning: variable ‘cci_clk_rate’ set but not used. > > > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11532 > > Fixes: 823dfb7bdb21 ("i2c: qcom-cci: Stop complaining about DT set clock rate") > > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > > --- > > Changes in v3: > > -Modify the commit message. > > Modify how? > What was the reason for ignoring the R-B tag? This patch has already been taken and I have added the R-B's as they were given. However, Jiapeng, please, next time try to be a bit more specific with the changelog, consider that people really read it. Andi
diff --git a/drivers/i2c/busses/i2c-qcom-cci.c b/drivers/i2c/busses/i2c-qcom-cci.c index 5cc791b3b57d..a0ef43e99751 100644 --- a/drivers/i2c/busses/i2c-qcom-cci.c +++ b/drivers/i2c/busses/i2c-qcom-cci.c @@ -523,7 +523,6 @@ static const struct dev_pm_ops qcom_cci_pm = { static int cci_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; - unsigned long cci_clk_rate = 0; struct device_node *child; struct resource *r; struct cci *cci; @@ -594,14 +593,6 @@ static int cci_probe(struct platform_device *pdev) return dev_err_probe(dev, -EINVAL, "not enough clocks in DT\n"); cci->nclocks = ret; - /* Retrieve CCI clock rate */ - for (i = 0; i < cci->nclocks; i++) { - if (!strcmp(cci->clocks[i].id, "cci")) { - cci_clk_rate = clk_get_rate(cci->clocks[i].clk); - break; - } - } - ret = cci_enable_clocks(cci); if (ret < 0) return ret;
Variable cci_clk_rate is not effectively used, so delete it. drivers/i2c/busses/i2c-qcom-cci.c:526:16: warning: variable ‘cci_clk_rate’ set but not used. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11532 Fixes: 823dfb7bdb21 ("i2c: qcom-cci: Stop complaining about DT set clock rate") Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- Changes in v3: -Modify the commit message. drivers/i2c/busses/i2c-qcom-cci.c | 9 --------- 1 file changed, 9 deletions(-)