| Message ID | 20241031234934.3451390-3-sandals@crustytoothpaste.net (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Improve CI testing of older systems | expand |
"brian m. carlson" <sandals@crustytoothpaste.net> writes: > We're no longer testing this version and it's well beyond regular LTS > support now, so remove the stanza for it from the case statement in our > CI code. Something like "we replaced it with 20.04 which does not need the corresponding special casing" would be necessary to explain why this is a good change, as opposed to an equally plausible-looking patch that replaces 16.04 with 20.04 and otherwise keeps the "stanza". > Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net> > --- > ci/install-dependencies.sh | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh > index 126e570eb4..d30ae53a18 100755 > --- a/ci/install-dependencies.sh > +++ b/ci/install-dependencies.sh > @@ -55,11 +55,6 @@ ubuntu-*|ubuntu32-*) > ${CC_PACKAGE:-${CC:-gcc}} $PYTHON_PACKAGE > > case "$distro" in > - ubuntu-16.04) > - # Does not support JGit, but we also don't really care about > - # the others. We rather care whether Git still compiles and > - # runs fine overall. > - ;; > ubuntu-*) > mkdir --parents "$CUSTOM_PATH" >
On 2024-11-01 at 00:34:14, Junio C Hamano wrote: > "brian m. carlson" <sandals@crustytoothpaste.net> writes: > > > We're no longer testing this version and it's well beyond regular LTS > > support now, so remove the stanza for it from the case statement in our > > CI code. > > Something like "we replaced it with 20.04 which does not need the > corresponding special casing" would be necessary to explain why this > is a good change, as opposed to an equally plausible-looking patch > that replaces 16.04 with 20.04 and otherwise keeps the "stanza". Sure, I can mention that in v2.
Junio C Hamano <gitster@pobox.com> writes: > "brian m. carlson" <sandals@crustytoothpaste.net> writes: > >> We're no longer testing this version and it's well beyond regular LTS >> support now, so remove the stanza for it from the case statement in our >> CI code. > > Something like "we replaced it with 20.04 which does not need the > corresponding special casing" would be necessary to explain why this > is a good change, as opposed to an equally plausible-looking patch > that replaces 16.04 with 20.04 and otherwise keeps the "stanza". Ah, I take it back (or atleast a half of it). We have been already using 20.04 on the .github/ side, and 1/3 removed only from .gitlab-ci removing the last user of 16.04, so presumably this has already tested well for 20.04 and there is no need to add "corresponding special casing". I'll keep reading the list backwards, this time resisting my temptation to utter nonsense without thinking much, attempting to catch up. Thanks. >> Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net> >> --- >> ci/install-dependencies.sh | 5 ----- >> 1 file changed, 5 deletions(-) >> >> diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh >> index 126e570eb4..d30ae53a18 100755 >> --- a/ci/install-dependencies.sh >> +++ b/ci/install-dependencies.sh >> @@ -55,11 +55,6 @@ ubuntu-*|ubuntu32-*) >> ${CC_PACKAGE:-${CC:-gcc}} $PYTHON_PACKAGE >> >> case "$distro" in >> - ubuntu-16.04) >> - # Does not support JGit, but we also don't really care about >> - # the others. We rather care whether Git still compiles and >> - # runs fine overall. >> - ;; >> ubuntu-*) >> mkdir --parents "$CUSTOM_PATH" >>
diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh index 126e570eb4..d30ae53a18 100755 --- a/ci/install-dependencies.sh +++ b/ci/install-dependencies.sh @@ -55,11 +55,6 @@ ubuntu-*|ubuntu32-*) ${CC_PACKAGE:-${CC:-gcc}} $PYTHON_PACKAGE case "$distro" in - ubuntu-16.04) - # Does not support JGit, but we also don't really care about - # the others. We rather care whether Git still compiles and - # runs fine overall. - ;; ubuntu-*) mkdir --parents "$CUSTOM_PATH"
We're no longer testing this version and it's well beyond regular LTS support now, so remove the stanza for it from the case statement in our CI code. Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net> --- ci/install-dependencies.sh | 5 ----- 1 file changed, 5 deletions(-)