| Message ID | 20241029163105.44135-1-vladimir.oltean@nxp.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [net] net: dpaa_eth: print FD status in CPU endianness in dpaa_eth_fd tracepoint | expand |
> -----Original Message----- > From: Vladimir Oltean <vladimir.oltean@nxp.com> > Sent: Tuesday, October 29, 2024 6:31 PM > To: netdev@vger.kernel.org; Radu-Andrei Bulie <radu-andrei.bulie@nxp.com> > Cc: David S. Miller <davem@davemloft.net>; Eric Dumazet > <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni > <pabeni@redhat.com>; Breno Leitao <leitao@debian.org>; Madalin Bucur > <madalin.bucur@nxp.com>; Ioana Ciornei <ioana.ciornei@nxp.com>; Christophe > Leroy <christophe.leroy@csgroup.eu>; Sean Anderson > <sean.anderson@linux.dev>; linux-kernel@vger.kernel.org; linuxppc- > dev@lists.ozlabs.org; linux-arm-kernel@lists.infradead.org > Subject: [PATCH net] net: dpaa_eth: print FD status in CPU endianness in > dpaa_eth_fd tracepoint > > Sparse warns: > > note: in included file (through ../include/trace/trace_events.h, > ../include/trace/define_trace.h, > ../drivers/net/ethernet/freescale/dpaa/dpaa_eth_trace.h): > warning: incorrect type in assignment (different base types) > expected unsigned int [usertype] fd_status > got restricted __be32 const [usertype] status > > We take struct qm_fd :: status, store it and print it as an u32, > though it is a big endian field. We should print the FD status in > CPU endianness for ease of debug and consistency between PowerPC and > Arm systems. > > Though it is a not often used debug feature, it is best to treat it as > a bug and backport the format change to all supported stable kernels, > for consistency. > > Fixes: eb11ddf36eb8 ("dpaa_eth: add trace points") > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> > --- > Context: https://lore.kernel.org/oe-kbuild-all/20241028-sticky-refined-lionfish- > b06c0c@leitao/ Acked-by: Madalin Bucur <madalin.bucur@oss.nxp.com>
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski <kuba@kernel.org>: On Tue, 29 Oct 2024 18:31:05 +0200 you wrote: > Sparse warns: > > note: in included file (through ../include/trace/trace_events.h, > ../include/trace/define_trace.h, > ../drivers/net/ethernet/freescale/dpaa/dpaa_eth_trace.h): > warning: incorrect type in assignment (different base types) > expected unsigned int [usertype] fd_status > got restricted __be32 const [usertype] status > > [...] Here is the summary with links: - [net] net: dpaa_eth: print FD status in CPU endianness in dpaa_eth_fd tracepoint https://git.kernel.org/netdev/net/c/0144c06c5890 You are awesome, thank you!
diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth_trace.h b/drivers/net/ethernet/freescale/dpaa/dpaa_eth_trace.h index 6f0e58a2a58a..9e1d44ae92cc 100644 --- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth_trace.h +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth_trace.h @@ -56,7 +56,7 @@ DECLARE_EVENT_CLASS(dpaa_eth_fd, __entry->fd_format = qm_fd_get_format(fd); __entry->fd_offset = qm_fd_get_offset(fd); __entry->fd_length = qm_fd_get_length(fd); - __entry->fd_status = fd->status; + __entry->fd_status = __be32_to_cpu(fd->status); __assign_str(name); ),
Sparse warns: note: in included file (through ../include/trace/trace_events.h, ../include/trace/define_trace.h, ../drivers/net/ethernet/freescale/dpaa/dpaa_eth_trace.h): warning: incorrect type in assignment (different base types) expected unsigned int [usertype] fd_status got restricted __be32 const [usertype] status We take struct qm_fd :: status, store it and print it as an u32, though it is a big endian field. We should print the FD status in CPU endianness for ease of debug and consistency between PowerPC and Arm systems. Though it is a not often used debug feature, it is best to treat it as a bug and backport the format change to all supported stable kernels, for consistency. Fixes: eb11ddf36eb8 ("dpaa_eth: add trace points") Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> --- Context: https://lore.kernel.org/oe-kbuild-all/20241028-sticky-refined-lionfish-b06c0c@leitao/ drivers/net/ethernet/freescale/dpaa/dpaa_eth_trace.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)