mbox series

[v4,0/2] uvc: Fix OOPs after rmmod if gpio unit is used

Message ID 20241105-uvc-crashrmmod-v4-0-410e548f097a@chromium.org (mailing list archive)
Headers show
Series uvc: Fix OOPs after rmmod if gpio unit is used | expand

Message

Ricardo Ribalda Nov. 5, 2024, 2:06 p.m. UTC 
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
---
Changes in v4: Thanks Laurent.
- Remove refcounted cleaup to support devres.
- Link to v3: https://lore.kernel.org/r/20241105-uvc-crashrmmod-v3-1-c0959c8906d3@chromium.org

Changes in v3: Thanks Sakari.
- Rename variable to initialized.
- Other CodeStyle.
- Link to v2: https://lore.kernel.org/r/20241105-uvc-crashrmmod-v2-1-547ce6a6962e@chromium.org

Changes in v2: Thanks to Laurent.
- The main structure is not allocated with devres so there is a small
  period of time where we can get an irq with the structure free. Do not
  use devres for the IRQ.
- Link to v1: https://lore.kernel.org/r/20241031-uvc-crashrmmod-v1-1-059fe593b1e6@chromium.org

---
Ricardo Ribalda (2):
      media: uvcvideo: Remove refcounted cleanup
      media: uvcvideo: Fix crash during unbind if gpio unit is in use

 drivers/media/usb/uvc/uvc_driver.c | 30 ++++++++----------------------
 drivers/media/usb/uvc/uvcvideo.h   |  1 -
 2 files changed, 8 insertions(+), 23 deletions(-)
---
base-commit: c7ccf3683ac9746b263b0502255f5ce47f64fe0a
change-id: 20241031-uvc-crashrmmod-666de3fc9141

Best regards,

Comments

Ricardo Ribalda Nov. 5, 2024, 2:12 p.m. UTC | #1 
Hi

Please ignore this version. I screwed it up when I prepared the set.

Sorry about that

On Tue, 5 Nov 2024 at 15:06, Ricardo Ribalda <ribalda@chromium.org> wrote:
>
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
> ---
> Changes in v4: Thanks Laurent.
> - Remove refcounted cleaup to support devres.
> - Link to v3: https://lore.kernel.org/r/20241105-uvc-crashrmmod-v3-1-c0959c8906d3@chromium.org
>
> Changes in v3: Thanks Sakari.
> - Rename variable to initialized.
> - Other CodeStyle.
> - Link to v2: https://lore.kernel.org/r/20241105-uvc-crashrmmod-v2-1-547ce6a6962e@chromium.org
>
> Changes in v2: Thanks to Laurent.
> - The main structure is not allocated with devres so there is a small
>   period of time where we can get an irq with the structure free. Do not
>   use devres for the IRQ.
> - Link to v1: https://lore.kernel.org/r/20241031-uvc-crashrmmod-v1-1-059fe593b1e6@chromium.org
>
> ---
> Ricardo Ribalda (2):
>       media: uvcvideo: Remove refcounted cleanup
>       media: uvcvideo: Fix crash during unbind if gpio unit is in use
>
>  drivers/media/usb/uvc/uvc_driver.c | 30 ++++++++----------------------
>  drivers/media/usb/uvc/uvcvideo.h   |  1 -
>  2 files changed, 8 insertions(+), 23 deletions(-)
> ---
> base-commit: c7ccf3683ac9746b263b0502255f5ce47f64fe0a
> change-id: 20241031-uvc-crashrmmod-666de3fc9141
>
> Best regards,
> --
> Ricardo Ribalda <ribalda@chromium.org>
>