| Message ID | Zys4hCj61V+mQfX2@v4bel-B760M-AORUS-ELITE-AX (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v2] hv_sock: Initializing vsk->trans to NULL to prevent a dangling pointer | expand |
On Wed, Nov 06, 2024 at 04:36:04AM -0500, Hyunwoo Kim wrote: >When hvs is released, there is a possibility that vsk->trans may not >be initialized to NULL, which could lead to a dangling pointer. >This issue is resolved by initializing vsk->trans to NULL. > >Fixes: ae0078fcf0a5 ("hv_sock: implements Hyper-V transport for Virtual Sockets (AF_VSOCK)") >Cc: stable@vger.kernel.org >Signed-off-by: Hyunwoo Kim <v4bel@theori.io> >--- >v1 -> v2: Add fixes and cc tags >--- > net/vmw_vsock/hyperv_transport.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Stefano Garzarella <sgarzare@redhat.com> > >diff --git a/net/vmw_vsock/hyperv_transport.c b/net/vmw_vsock/hyperv_transport.c >index e2157e387217..56c232cf5b0f 100644 >--- a/net/vmw_vsock/hyperv_transport.c >+++ b/net/vmw_vsock/hyperv_transport.c >@@ -549,6 +549,7 @@ static void hvs_destruct(struct vsock_sock *vsk) > vmbus_hvsock_device_unregister(chan); > > kfree(hvs); >+ vsk->trans = NULL; > } > > static int hvs_dgram_bind(struct vsock_sock *vsk, struct sockaddr_vm *addr) >-- >2.34.1 >
On Wed, Nov 06, 2024 at 04:36:04AM -0500, Hyunwoo Kim wrote: > When hvs is released, there is a possibility that vsk->trans may not > be initialized to NULL, which could lead to a dangling pointer. > This issue is resolved by initializing vsk->trans to NULL. > > Fixes: ae0078fcf0a5 ("hv_sock: implements Hyper-V transport for Virtual Sockets (AF_VSOCK)") > Cc: stable@vger.kernel.org > Signed-off-by: Hyunwoo Kim <v4bel@theori.io> Acked-by: Michael S. Tsirkin <mst@redhat.com> > --- > v1 -> v2: Add fixes and cc tags > --- > net/vmw_vsock/hyperv_transport.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/net/vmw_vsock/hyperv_transport.c b/net/vmw_vsock/hyperv_transport.c > index e2157e387217..56c232cf5b0f 100644 > --- a/net/vmw_vsock/hyperv_transport.c > +++ b/net/vmw_vsock/hyperv_transport.c > @@ -549,6 +549,7 @@ static void hvs_destruct(struct vsock_sock *vsk) > vmbus_hvsock_device_unregister(chan); > > kfree(hvs); > + vsk->trans = NULL; > } > > static int hvs_dgram_bind(struct vsock_sock *vsk, struct sockaddr_vm *addr) > -- > 2.34.1
diff --git a/net/vmw_vsock/hyperv_transport.c b/net/vmw_vsock/hyperv_transport.c index e2157e387217..56c232cf5b0f 100644 --- a/net/vmw_vsock/hyperv_transport.c +++ b/net/vmw_vsock/hyperv_transport.c @@ -549,6 +549,7 @@ static void hvs_destruct(struct vsock_sock *vsk) vmbus_hvsock_device_unregister(chan); kfree(hvs); + vsk->trans = NULL; } static int hvs_dgram_bind(struct vsock_sock *vsk, struct sockaddr_vm *addr)
When hvs is released, there is a possibility that vsk->trans may not be initialized to NULL, which could lead to a dangling pointer. This issue is resolved by initializing vsk->trans to NULL. Fixes: ae0078fcf0a5 ("hv_sock: implements Hyper-V transport for Virtual Sockets (AF_VSOCK)") Cc: stable@vger.kernel.org Signed-off-by: Hyunwoo Kim <v4bel@theori.io> --- v1 -> v2: Add fixes and cc tags --- net/vmw_vsock/hyperv_transport.c | 1 + 1 file changed, 1 insertion(+)