diff mbox series

[v2,1/2] dt-bindings: arm: mediatek: Add MT8188 Lenovo Chromebook Duet (11", 9)

Message ID 20241105093222.4055774-2-fshao@chromium.org (mailing list archive)
State New
Headers show
Series Add device tree for MT8188-based Chromebook "Ciri" | expand

Commit Message

Fei Shao Nov. 5, 2024, 9:30 a.m. UTC
Add entries for the MT8188-based Chromebook "Ciri", also known as
Lenovo Chromebook Duet (11", 9).

This device features a detachable design with touchscreen, detachable
keyboard and USI 2.0 Stylus support, and has 8 SKUs to accommodate the
combinations of second-source components.

Signed-off-by: Fei Shao <fshao@chromium.org>
---

(no changes since v1)

 Documentation/devicetree/bindings/arm/mediatek.yaml | 13 +++++++++++++
 1 file changed, 13 insertions(+)

Comments

Krzysztof Kozlowski Nov. 5, 2024, 2:06 p.m. UTC | #1
On 05/11/2024 10:30, Fei Shao wrote:
> Add entries for the MT8188-based Chromebook "Ciri", also known as
> Lenovo Chromebook Duet (11", 9).
> 
> This device features a detachable design with touchscreen, detachable
> keyboard and USI 2.0 Stylus support, and has 8 SKUs to accommodate the
> combinations of second-source components.
> 
> Signed-off-by: Fei Shao <fshao@chromium.org>

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
AngeloGioacchino Del Regno Nov. 6, 2024, 1:19 p.m. UTC | #2
Il 05/11/24 10:30, Fei Shao ha scritto:
> Add entries for the MT8188-based Chromebook "Ciri", also known as
> Lenovo Chromebook Duet (11", 9).
> 
> This device features a detachable design with touchscreen, detachable
> keyboard and USI 2.0 Stylus support, and has 8 SKUs to accommodate the
> combinations of second-source components.
> 
> Signed-off-by: Fei Shao <fshao@chromium.org>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>


> ---
> 
> (no changes since v1)
> 
>   Documentation/devicetree/bindings/arm/mediatek.yaml | 13 +++++++++++++
>   1 file changed, 13 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
> index 1d4bb50fcd8d..4b68f0baf010 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
> +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
> @@ -307,6 +307,19 @@ properties:
>             - enum:
>                 - mediatek,mt8186-evb
>             - const: mediatek,mt8186
> +      - description: Google Ciri (Lenovo Chromebook Duet (11", 9))
> +        items:
> +          - enum:
> +              - google,ciri-sku0
> +              - google,ciri-sku1
> +              - google,ciri-sku2
> +              - google,ciri-sku3
> +              - google,ciri-sku4
> +              - google,ciri-sku5
> +              - google,ciri-sku6
> +              - google,ciri-sku7
> +          - const: google,ciri
> +          - const: mediatek,mt8188
>         - items:
>             - enum:
>                 - mediatek,mt8188-evb
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
index 1d4bb50fcd8d..4b68f0baf010 100644
--- a/Documentation/devicetree/bindings/arm/mediatek.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
@@ -307,6 +307,19 @@  properties:
           - enum:
               - mediatek,mt8186-evb
           - const: mediatek,mt8186
+      - description: Google Ciri (Lenovo Chromebook Duet (11", 9))
+        items:
+          - enum:
+              - google,ciri-sku0
+              - google,ciri-sku1
+              - google,ciri-sku2
+              - google,ciri-sku3
+              - google,ciri-sku4
+              - google,ciri-sku5
+              - google,ciri-sku6
+              - google,ciri-sku7
+          - const: google,ciri
+          - const: mediatek,mt8188
       - items:
           - enum:
               - mediatek,mt8188-evb