| Message ID | 20241106090311.17536-2-alexisczezar.torreno@analog.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Add support for ADP1051 and ADP1055 | expand |
On Wed, Nov 06, 2024 at 05:03:10PM +0800, Alexis Cezar Torreno wrote: > Add dt-bindings for adp1051 and adp1055 pmbus. > ADP1051: 6 PWM for I/O Voltage, I/O Current, Temperature > ADP1055: 6 PWM for I/O Voltage, I/O Current, Power, Temperature > > Signed-off-by: Alexis Cezar Torreno <alexisczezar.torreno@analog.com> > --- > .../devicetree/bindings/hwmon/pmbus/adi,adp1050.yaml | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.yaml > index 10c2204bc3df..88aaa29b3bd1 100644 > --- a/Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.yaml > +++ b/Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.yaml > @@ -10,16 +10,24 @@ maintainers: > - Radu Sabau <radu.sabau@analog.com> > > description: | > - The ADP1050 is used to monitor system voltages, currents and temperatures. > + The ADP1050 and similar devices are used to monitor system voltages, > + currents, power, and temperatures. > + > Through the PMBus interface, the ADP1050 targets isolated power supplies > and has four individual monitors for input/output voltage, input current > and temperature. > Datasheet: > https://www.analog.com/en/products/adp1050.html > + https://www.analog.com/en/products/adp1051.html > + https://www.analog.com/en/products/adp1055.html > > properties: > + That's an abnormal newline, leave it alone if you respin. Acked-by: Conor Dooley <conor.dooley@microchip.com> Cheers, Conor. > compatible: > - const: adi,adp1050 > + enum: > + - adi,adp1050 > + - adi,adp1051 > + - adi,adp1055 > > reg: > maxItems: 1 > -- > 2.34.1 >
> -----Original Message----- > From: Conor Dooley <conor@kernel.org> > Sent: Wednesday, November 6, 2024 11:49 PM > To: Torreno, Alexis Czezar <AlexisCzezar.Torreno@analog.com> > Cc: linux-doc@vger.kernel.org; linux-kernel@vger.kernel.org; > devicetree@vger.kernel.org; linux-hwmon@vger.kernel.org; Sabau, Radu > bogdan <Radu.Sabau@analog.com>; Jean Delvare <jdelvare@suse.com>; > Guenter Roeck <linux@roeck-us.net>; Rob Herring <robh@kernel.org>; > Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor Dooley > <conor+dt@kernel.org>; Jonathan Corbet <corbet@lwn.net>; Andy > Shevchenko <andriy.shevchenko@linux.intel.com>; Uwe Kleine-König > <u.kleine-koenig@pengutronix.de> > Subject: Re: [PATCH 1/2] dt-bindings: hwmon: (pmbus/adp1050): Support > adp1051 and adp1055: add bindings. > > [External] > > On Wed, Nov 06, 2024 at 05:03:10PM +0800, Alexis Cezar Torreno wrote: > > Add dt-bindings for adp1051 and adp1055 pmbus. > > ADP1051: 6 PWM for I/O Voltage, I/O Current, Temperature > > ADP1055: 6 PWM for I/O Voltage, I/O Current, Power, Temperature > > > > Signed-off-by: Alexis Cezar Torreno <alexisczezar.torreno@analog.com> > > --- > > .../devicetree/bindings/hwmon/pmbus/adi,adp1050.yaml | 12 ++++++++++- > - > > 1 file changed, 10 insertions(+), 2 deletions(-) > > > > diff --git > a/Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.yaml > b/Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.yaml > > index 10c2204bc3df..88aaa29b3bd1 100644 > > --- a/Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.yaml > > +++ > b/Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.yaml > > @@ -10,16 +10,24 @@ maintainers: > > - Radu Sabau <radu.sabau@analog.com> > > > > description: | > > - The ADP1050 is used to monitor system voltages, currents and > temperatures. > > + The ADP1050 and similar devices are used to monitor system voltages, > > + currents, power, and temperatures. > > + > > Through the PMBus interface, the ADP1050 targets isolated power supplies > > and has four individual monitors for input/output voltage, input current > > and temperature. > > Datasheet: > > https://www.analog.com/en/products/adp1050.html > > + https://www.analog.com/en/products/adp1051.html > > + https://www.analog.com/en/products/adp1055.html > > > > properties: > > + > > That's an abnormal newline, leave it alone if you respin. > > Acked-by: Conor Dooley <conor.dooley@microchip.com> > > Cheers, > Conor. Will remove/revert the newline. Thanks! Regards, Alexis > > > compatible: > > - const: adi,adp1050 > > + enum: > > + - adi,adp1050 > > + - adi,adp1051 > > + - adi,adp1055 > > > > reg: > > maxItems: 1 > > -- > > 2.34.1 > >
diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.yaml index 10c2204bc3df..88aaa29b3bd1 100644 --- a/Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.yaml +++ b/Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.yaml @@ -10,16 +10,24 @@ maintainers: - Radu Sabau <radu.sabau@analog.com> description: | - The ADP1050 is used to monitor system voltages, currents and temperatures. + The ADP1050 and similar devices are used to monitor system voltages, + currents, power, and temperatures. + Through the PMBus interface, the ADP1050 targets isolated power supplies and has four individual monitors for input/output voltage, input current and temperature. Datasheet: https://www.analog.com/en/products/adp1050.html + https://www.analog.com/en/products/adp1051.html + https://www.analog.com/en/products/adp1055.html properties: + compatible: - const: adi,adp1050 + enum: + - adi,adp1050 + - adi,adp1051 + - adi,adp1055 reg: maxItems: 1
Add dt-bindings for adp1051 and adp1055 pmbus. ADP1051: 6 PWM for I/O Voltage, I/O Current, Temperature ADP1055: 6 PWM for I/O Voltage, I/O Current, Power, Temperature Signed-off-by: Alexis Cezar Torreno <alexisczezar.torreno@analog.com> --- .../devicetree/bindings/hwmon/pmbus/adi,adp1050.yaml | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-)