| Message ID | 20241107060254.17615-11-mario.limonciello@amd.com (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Add support for binding ACPI platform profile to multiple drivers | expand |
Am 07.11.24 um 07:02 schrieb Mario Limonciello: > The name attribute shows the name of the associated platform profile > handler. > > Tested-by: Mark Pearson <mpearson-lenovo@squebb.ca> > Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> > --- > v5: > * Drop newline > * Add mutex for sysfs access > --- > drivers/acpi/platform_profile.c | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/drivers/acpi/platform_profile.c b/drivers/acpi/platform_profile.c > index 9caf070f77f6a..f605c2bd35c68 100644 > --- a/drivers/acpi/platform_profile.c > +++ b/drivers/acpi/platform_profile.c > @@ -25,8 +25,35 @@ static_assert(ARRAY_SIZE(profile_names) == PLATFORM_PROFILE_LAST); > > static DEFINE_IDA(platform_profile_ida); > > +/** > + * name_show - Show the name of the profile handler > + * @dev: The device > + * @attr: The attribute > + * @buf: The buffer to write to > + * Return: The number of bytes written > + */ > +static ssize_t name_show(struct device *dev, > + struct device_attribute *attr, > + char *buf) > +{ > + scoped_cond_guard(mutex_intr, return -ERESTARTSYS, &profile_lock) { > + struct platform_profile_handler *handler = dev_get_drvdata(dev); > + > + return sysfs_emit(buf, "%s\n", handler->name); > + } > + return -ERESTARTSYS; Is the mutex really necessary here? The name remains static across the lifetime of the platform profile. Thanks, Armin Wolf > +} > + > +static DEVICE_ATTR_RO(name); > +static struct attribute *profile_attrs[] = { > + &dev_attr_name.attr, > + NULL > +}; > +ATTRIBUTE_GROUPS(profile); > + > static const struct class platform_profile_class = { > .name = "platform-profile", > + .dev_groups = profile_groups, > }; > > static ssize_t platform_profile_choices_show(struct device *dev,
diff --git a/drivers/acpi/platform_profile.c b/drivers/acpi/platform_profile.c index 9caf070f77f6a..f605c2bd35c68 100644 --- a/drivers/acpi/platform_profile.c +++ b/drivers/acpi/platform_profile.c @@ -25,8 +25,35 @@ static_assert(ARRAY_SIZE(profile_names) == PLATFORM_PROFILE_LAST); static DEFINE_IDA(platform_profile_ida); +/** + * name_show - Show the name of the profile handler + * @dev: The device + * @attr: The attribute + * @buf: The buffer to write to + * Return: The number of bytes written + */ +static ssize_t name_show(struct device *dev, + struct device_attribute *attr, + char *buf) +{ + scoped_cond_guard(mutex_intr, return -ERESTARTSYS, &profile_lock) { + struct platform_profile_handler *handler = dev_get_drvdata(dev); + + return sysfs_emit(buf, "%s\n", handler->name); + } + return -ERESTARTSYS; +} + +static DEVICE_ATTR_RO(name); +static struct attribute *profile_attrs[] = { + &dev_attr_name.attr, + NULL +}; +ATTRIBUTE_GROUPS(profile); + static const struct class platform_profile_class = { .name = "platform-profile", + .dev_groups = profile_groups, }; static ssize_t platform_profile_choices_show(struct device *dev,