[v2,0/3] scftorture: Avoid kfree from IRQ context.

Message ID	20241107111821.3417762-1-bigeasy@linutronix.de (mailing list archive)
Headers	show Return-Path: <owner-linux-mm@kvack.org> From: Sebastian Andrzej Siewior <bigeasy@linutronix.de> To: kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: "Paul E. McKenney" <paulmck@kernel.org>, Boqun Feng <boqun.feng@gmail.com>, Marco Elver <elver@google.com>, Peter Zijlstra <peterz@infradead.org>, Tomas Gleixner <tglx@linutronix.de>, Vlastimil Babka <vbabka@suse.cz>, akpm@linux-foundation.org, cl@linux.com, iamjoonsoo.kim@lge.com, longman@redhat.com, penberg@kernel.org, rientjes@google.com, sfr@canb.auug.org.au Subject: [PATCH v2 0/3] scftorture: Avoid kfree from IRQ context. Date: Thu, 7 Nov 2024 12:13:05 +0100 Message-ID: <20241107111821.3417762-1-bigeasy@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sender: owner-linux-mm@kvack.org Precedence: bulk
Series	scftorture: Avoid kfree from IRQ context. \| expand [v2,0/3] scftorture: Avoid kfree from IRQ context. [v2,1/3] scftorture: Avoid additional div operation. [v2,2/3] scftorture: Move memory allocation outside of preempt_disable region. [v2,3/3] scftorture: Use a lock-less list to free memory. [v2,4/3] scftorture: Wait until scf_cleanup_handler() completes.

Message ID

20241107111821.3417762-1-bigeasy@linutronix.de (mailing list archive)

Headers

From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: kasan-dev@googlegroups.com,
	linux-kernel@vger.kernel.org,
	linux-mm@kvack.org
Cc: "Paul E. McKenney" <paulmck@kernel.org>,
	Boqun Feng <boqun.feng@gmail.com>,
	Marco Elver <elver@google.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Tomas Gleixner <tglx@linutronix.de>,
	Vlastimil Babka <vbabka@suse.cz>,
	akpm@linux-foundation.org,
	cl@linux.com,
	iamjoonsoo.kim@lge.com,
	longman@redhat.com,
	penberg@kernel.org,
	rientjes@google.com,
	sfr@canb.auug.org.au
Subject: [PATCH v2 0/3] scftorture: Avoid kfree from IRQ context.
Date: Thu,  7 Nov 2024 12:13:05 +0100
Message-ID: <20241107111821.3417762-1-bigeasy@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Sender: owner-linux-mm@kvack.org
Precedence: bulk

Series

scftorture: Avoid kfree from IRQ context. | expand

Message

Sebastian Andrzej Siewior Nov. 7, 2024, 11:13 a.m. UTC

Hi,

Paul reported kfree from IRQ context in scftorture which is noticed by
lockdep since the recent PROVE_RAW_LOCK_NESTING switch.

The last patch in this series adresses the issues, the other things
happened on the way.

v1…v2:
  - Remove kfree_bulk(). I get more invocations per report without it.
  - Pass `cpu' to scf_cleanup_free_list in scftorture_invoker() instead
    of scfp->cpu. The latter is the thread number which can be larger
    than the number CPUs leading to a crash in such a case. Reported by
    Boqun Feng.
  - Clean up the per-CPU lists on module exit. Reported by Boqun Feng.

Sebastian

Comments

Paul E. McKenney Nov. 7, 2024, 7:05 p.m. UTC | #1

On Thu, Nov 07, 2024 at 12:13:05PM +0100, Sebastian Andrzej Siewior wrote:
> Hi,
> 
> Paul reported kfree from IRQ context in scftorture which is noticed by
> lockdep since the recent PROVE_RAW_LOCK_NESTING switch.
> 
> The last patch in this series adresses the issues, the other things
> happened on the way.

For the series:

Tested-by: Paul E. McKenney <paulmck@kernel.org>

> v1…v2:
>   - Remove kfree_bulk(). I get more invocations per report without it.
>   - Pass `cpu' to scf_cleanup_free_list in scftorture_invoker() instead
>     of scfp->cpu. The latter is the thread number which can be larger
>     than the number CPUs leading to a crash in such a case. Reported by
>     Boqun Feng.
>   - Clean up the per-CPU lists on module exit. Reported by Boqun Feng.
> 
> Sebastian
>