diff mbox series

[10/10] drm/i915/crt: Nuke unused crt->connector

Message ID 20241107161123.16269-11-ville.syrjala@linux.intel.com (mailing list archive)
State New
Headers show
Series drm/i915: Potential boot oops fix and some cleanups | expand

Commit Message

Ville Syrjala Nov. 7, 2024, 4:11 p.m. UTC 
From: Ville Syrjälä <ville.syrjala@linux.intel.com>

crt->connector is never used, nuke it.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_crt.c | 5 -----
 1 file changed, 5 deletions(-)

Comments

Jani Nikula Nov. 8, 2024, 1:16 p.m. UTC | #1 
On Thu, 07 Nov 2024, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> crt->connector is never used, nuke it.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

I'll trust the compiler.

Reviewed-by: Jani Nikula <jani.nikula@intel.com>


> ---
>  drivers/gpu/drm/i915/display/intel_crt.c | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_crt.c b/drivers/gpu/drm/i915/display/intel_crt.c
> index b243ab51bdf0..139810ed4baa 100644
> --- a/drivers/gpu/drm/i915/display/intel_crt.c
> +++ b/drivers/gpu/drm/i915/display/intel_crt.c
> @@ -73,9 +73,6 @@
>  
>  struct intel_crt {
>  	struct intel_encoder base;
> -	/* DPMS state is stored in the connector, which we need in the
> -	 * encoder's enable/disable callbacks */
> -	struct intel_connector *connector;
>  	bool force_hotplug_required;
>  	i915_reg_t adpa_reg;
>  };
> @@ -1067,8 +1064,6 @@ void intel_crt_init(struct intel_display *display)
>  
>  	ddc_pin = display->vbt.crt_ddc_pin;
>  
> -	crt->connector = connector;
> -
>  	drm_connector_init_with_ddc(display->drm, &connector->base,
>  				    &intel_crt_connector_funcs,
>  				    DRM_MODE_CONNECTOR_VGA,
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/display/intel_crt.c b/drivers/gpu/drm/i915/display/intel_crt.c
index b243ab51bdf0..139810ed4baa 100644
--- a/drivers/gpu/drm/i915/display/intel_crt.c
+++ b/drivers/gpu/drm/i915/display/intel_crt.c
@@ -73,9 +73,6 @@ 
 
 struct intel_crt {
 	struct intel_encoder base;
-	/* DPMS state is stored in the connector, which we need in the
-	 * encoder's enable/disable callbacks */
-	struct intel_connector *connector;
 	bool force_hotplug_required;
 	i915_reg_t adpa_reg;
 };
@@ -1067,8 +1064,6 @@  void intel_crt_init(struct intel_display *display)
 
 	ddc_pin = display->vbt.crt_ddc_pin;
 
-	crt->connector = connector;
-
 	drm_connector_init_with_ddc(display->drm, &connector->base,
 				    &intel_crt_connector_funcs,
 				    DRM_MODE_CONNECTOR_VGA,