diff mbox series

[v4,1/6] dt-bindings: Add Blaize vendor prefix

Message ID 20241108103120.9955-2-nikolaos.pasaloukos@blaize.com (mailing list archive)
State New
Headers show
Series Add support for Blaize BLZP1600 SoC | expand

Commit Message

Nikolaos Pasaloukos Nov. 8, 2024, 10:31 a.m. UTC
Blaize, Inc. (www.blaize.com) is a SoC manufacturer with integrated
programmable Graph-Streaming-Processors for AI and ML.

Resolves: PESW-2604
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
Signed-off-by: Nikolaos Pasaloukos <nikolaos.pasaloukos@blaize.com>
---
 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)

Comments

Krzysztof Kozlowski Nov. 8, 2024, 10:54 a.m. UTC | #1
On 08/11/2024 11:31, Niko Pasaloukos wrote:
> Blaize, Inc. (www.blaize.com) is a SoC manufacturer with integrated
> programmable Graph-Streaming-Processors for AI and ML.
> 
> Resolves: PESW-2604

What is this? The tag and the meaning? How does it matter for the upstream?

I do not see you using b4 so I do no understand why you Cc stale
addresses. Standard reply - please fix your process:

<form letter>
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC (and consider --no-git-fallback argument, so you will
not CC people just because they made one commit years ago). It might
happen, that command when run on an older kernel, gives you outdated
entries. Therefore please be sure you base your patches on recent Linux
kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.
</form letter>

Best regards,
Krzysztof
Krzysztof Kozlowski Nov. 8, 2024, 12:06 p.m. UTC | #2
On Fri, Nov 08, 2024 at 10:31:55AM +0000, Niko Pasaloukos wrote:
> Blaize, Inc. (www.blaize.com) is a SoC manufacturer with integrated
> programmable Graph-Streaming-Processors for AI and ML.
> 
> Resolves: PESW-2604
> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
> Signed-off-by: Nikolaos Pasaloukos <nikolaos.pasaloukos@blaize.com>

This has checkpatch issues. Your patches claim to ignore them
intentionally: sorry that's not accepted.

The checkpatch error you have here is very odd and points to
misconfigured system. You must fix it.

Best regards,
Krzysztof
Nikolaos Pasaloukos Nov. 8, 2024, 2:18 p.m. UTC | #3
On 08/11/2024 10:54, Krzysztof Kozlowski wrote:
> On 08/11/2024 11:31, Niko Pasaloukos wrote:
>> Blaize, Inc. (www.blaize.com) is a SoC manufacturer with integrated
>> programmable Graph-Streaming-Processors for AI and ML.
>>
>> Resolves: PESW-2604
> What is this? The tag and the meaning? How does it matter for the upstream?

Hi Krzysztof,

First of all, thank you very much for your fast review.
Apologies for not rebasing to the correct branch and having so many people in the list.
Also, adding the --no-git-fallback reduced the list even more. Thank you very much.
Apologies for not deleting the internal tags and causing confusion. V5 will have all these fixed.

Best regards,
Niko

>
> I do not see you using b4 so I do no understand why you Cc stale
> addresses. Standard reply - please fix your process:
>
> <form letter>
> Please use scripts/get_maintainers.pl to get a list of necessary people
> and lists to CC (and consider --no-git-fallback argument, so you will
> not CC people just because they made one commit years ago). It might
> happen, that command when run on an older kernel, gives you outdated
> entries. Therefore please be sure you base your patches on recent Linux
> kernel.
>
> Tools like b4 or scripts/get_maintainer.pl provide you proper list of
> people, so fix your workflow. Tools might also fail if you work on some
> ancient tree (don't, instead use mainline) or work on fork of kernel
> (don't, instead use mainline). Just use b4 and everything should be
> fine, although remember about `b4 prep --auto-to-cc` if you added new
> patches to the patchset.
> </form letter>
>
> Best regards,
> Krzysztof
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index b97d298b3eb6..746ff14028d1 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -214,6 +214,8 @@  patternProperties:
     description: Shenzhen BigTree Tech Co., LTD
   "^bitmain,.*":
     description: Bitmain Technologies
+  "^blaize,.*":
+    description: Blaize, Inc.
   "^blutek,.*":
     description: BluTek Power
   "^boe,.*":