diff mbox series

[v3,5/5] arm64: dts: imx93-9x9-qsb: add temp-sensor nxp,p3t1085

Message ID 20241111-p3t1085-v3-5-bff511550aad@nxp.com (mailing list archive)
State New
Headers show
Series hwmon: tmp108: Add support for P3T1085 | expand

Commit Message

Frank Li Nov. 11, 2024, 5:32 p.m. UTC
Add temp-sensor nxp,p3t1085 for imx93-9x9-qsb boards.

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
change from v1 to v3
- none
---
 arch/arm64/boot/dts/freescale/imx93-9x9-qsb.dts | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Marco Felsch Nov. 11, 2024, 7:13 p.m. UTC | #1
Hi,

On 24-11-11, Frank Li wrote:
> Add temp-sensor nxp,p3t1085 for imx93-9x9-qsb boards.
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> change from v1 to v3
> - none
> ---
>  arch/arm64/boot/dts/freescale/imx93-9x9-qsb.dts | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx93-9x9-qsb.dts b/arch/arm64/boot/dts/freescale/imx93-9x9-qsb.dts
> index 20ec5b3c21f42..36f2995acbe29 100644
> --- a/arch/arm64/boot/dts/freescale/imx93-9x9-qsb.dts
> +++ b/arch/arm64/boot/dts/freescale/imx93-9x9-qsb.dts
> @@ -221,6 +221,11 @@ wm8962: audio-codec@1a {
>  		>;
>  	};
>  
> +	p3t1085: temperature-sensor@48 {
> +		compatible = "nxp,p3t1085";
> +		reg = <0x48>;
> +	};

Out of curiosity, did you tested that the I3C is working on a real
device, since you added the node here as I2C device? If not, please skip
adding the I3C part and keep it as TODO for later.

Regards,
  Marco

>  	ptn5110: tcpc@50 {
>  		compatible = "nxp,ptn5110", "tcpci";
>  		reg = <0x50>;
> 
> -- 
> 2.34.1
> 
> 
>
Frank Li Nov. 11, 2024, 7:24 p.m. UTC | #2
On Mon, Nov 11, 2024 at 08:13:11PM +0100, Marco Felsch wrote:
> Hi,
>
> On 24-11-11, Frank Li wrote:
> > Add temp-sensor nxp,p3t1085 for imx93-9x9-qsb boards.
> >
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> > change from v1 to v3
> > - none
> > ---
> >  arch/arm64/boot/dts/freescale/imx93-9x9-qsb.dts | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx93-9x9-qsb.dts b/arch/arm64/boot/dts/freescale/imx93-9x9-qsb.dts
> > index 20ec5b3c21f42..36f2995acbe29 100644
> > --- a/arch/arm64/boot/dts/freescale/imx93-9x9-qsb.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx93-9x9-qsb.dts
> > @@ -221,6 +221,11 @@ wm8962: audio-codec@1a {
> >  		>;
> >  	};
> >
> > +	p3t1085: temperature-sensor@48 {
> > +		compatible = "nxp,p3t1085";
> > +		reg = <0x48>;
> > +	};
>
> Out of curiosity, did you tested that the I3C is working on a real
> device, since you added the node here as I2C device? If not, please skip
> adding the I3C part and keep it as TODO for later.

Yes, it work as i3c. I3C device can auto probe according to PID
information, needn't add dt node for i3c device if it needn't power-supply
or some special settings.

Frank

>
> Regards,
>   Marco
>
> >  	ptn5110: tcpc@50 {
> >  		compatible = "nxp,ptn5110", "tcpci";
> >  		reg = <0x50>;
> >
> > --
> > 2.34.1
> >
> >
> >
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/freescale/imx93-9x9-qsb.dts b/arch/arm64/boot/dts/freescale/imx93-9x9-qsb.dts
index 20ec5b3c21f42..36f2995acbe29 100644
--- a/arch/arm64/boot/dts/freescale/imx93-9x9-qsb.dts
+++ b/arch/arm64/boot/dts/freescale/imx93-9x9-qsb.dts
@@ -221,6 +221,11 @@  wm8962: audio-codec@1a {
 		>;
 	};
 
+	p3t1085: temperature-sensor@48 {
+		compatible = "nxp,p3t1085";
+		reg = <0x48>;
+	};
+
 	ptn5110: tcpc@50 {
 		compatible = "nxp,ptn5110", "tcpci";
 		reg = <0x50>;