| Message ID | 20241112072049.765097-1-jpatel2@marvell.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [1/1] arm64: dts: marvell: mcbin: fix PCIe reset property | expand |
On Mon, Nov 11, 2024 at 11:20:49PM -0800, Jenishkumar Maheshbhai Patel wrote: > Set reset gpio to active high > > Fixes: b83e1669adce ("arm64: dts: marvell: mcbin: add support for PCIe") > > Signed-off-by: Jenishkumar Maheshbhai Patel <jpatel2@marvell.com> > --- > arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi > index c864df9ec84d..a8c732a47360 100644 > --- a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi > +++ b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi > @@ -181,7 +181,7 @@ &cp0_pcie0 { > pinctrl-0 = <&cp0_pcie_pins>; > num-lanes = <4>; > num-viewport = <8>; > - reset-gpios = <&cp0_gpio2 20 GPIO_ACTIVE_LOW>; > + reset-gpios = <&cp0_gpio2 20 GPIO_ACTIVE_HIGH>; Is this change due to switching the driver to use the reset controller? If so, NAK to all the changes - DT files are meant to be forwards compatible (older DT are supposed to work with newer kernels) and it would seem this would break that rule.
diff --git a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi index c864df9ec84d..a8c732a47360 100644 --- a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi +++ b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi @@ -181,7 +181,7 @@ &cp0_pcie0 { pinctrl-0 = <&cp0_pcie_pins>; num-lanes = <4>; num-viewport = <8>; - reset-gpios = <&cp0_gpio2 20 GPIO_ACTIVE_LOW>; + reset-gpios = <&cp0_gpio2 20 GPIO_ACTIVE_HIGH>; ranges = <0x82000000 0x0 0xc0000000 0x0 0xc0000000 0x0 0x20000000>; phys = <&cp0_comphy0 0>, <&cp0_comphy1 0>, <&cp0_comphy2 0>, <&cp0_comphy3 0>;
Set reset gpio to active high Fixes: b83e1669adce ("arm64: dts: marvell: mcbin: add support for PCIe") Signed-off-by: Jenishkumar Maheshbhai Patel <jpatel2@marvell.com> --- arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)