mbox series

[net,v1,0/2] Fix ethtool --show-eee for stmmac

Message ID 20241112072447.3238892-1-yong.liang.choong@linux.intel.com (mailing list archive)
Headers show
Series Fix ethtool --show-eee for stmmac | expand

Message

Choong Yong Liang Nov. 12, 2024, 7:24 a.m. UTC 
This fix ensures that 'ethtool --show-eee' displays the correct
status for stmmac.

Choong Yong Liang (2):
  net: phy: Introduce phy_update_eee() to update eee_cfg values
  net: stmmac: update eee_cfg after mac link up/down

 .../net/ethernet/stmicro/stmmac/stmmac_main.c |  4 ++++
 drivers/net/phy/phy_device.c                  | 24 +++++++++++++++++++
 include/linux/phy.h                           |  2 ++
 3 files changed, 30 insertions(+)

Comments

Russell King (Oracle) Nov. 12, 2024, 9:24 a.m. UTC | #1 
On Tue, Nov 12, 2024 at 03:24:45PM +0800, Choong Yong Liang wrote:
> This fix ensures that 'ethtool --show-eee' displays the correct
> status for stmmac.

What do you think is wrong? It seems stmmac is manipulating eee_enabled
depending on something. This is wrong. eee_enabled is a _user_
_configuration_ bit, not a status bit. If the user sets eee_enabled to
a particular state, then the user expects it to stay that way and not
be manipulated by the driver.