diff mbox series

fstests: check for ext3 support in btrfs/136

Message ID 4c41adf81241f5d23b5a10251564b1630cabc500.1731327765.git.jth@kernel.org (mailing list archive)
State New
Headers show
Series fstests: check for ext3 support in btrfs/136 | expand

Commit Message

Johannes Thumshirn Nov. 11, 2024, 12:24 p.m. UTC
Test-case btrfs/136 requires ext3 support, so check for ext3 using
_require_extra_fs.

Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
---
 tests/btrfs/136 | 2 ++
 1 file changed, 2 insertions(+)

Comments

Zorro Lang Nov. 11, 2024, 7:45 p.m. UTC | #1
On Mon, Nov 11, 2024 at 01:24:53PM +0100, Johannes Thumshirn wrote:
> Test-case btrfs/136 requires ext3 support, so check for ext3 using
> _require_extra_fs.
> 
> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
> ---

Makes sense to me,

Reviewed-by: Zorro Lang <zlang@redhat.com>

>  tests/btrfs/136 | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/btrfs/136 b/tests/btrfs/136
> index 9b5b3331119f..2a5280fb9bd1 100755
> --- a/tests/btrfs/136
> +++ b/tests/btrfs/136
> @@ -20,6 +20,8 @@ _require_scratch_nocheck
>  # ext4 does not support zoned block device
>  _require_non_zoned_device "${SCRATCH_DEV}"
>  
> +_require_extra_fs ext3
> +
>  _require_command "$BTRFS_CONVERT_PROG" btrfs-convert
>  _require_command "$MKFS_EXT4_PROG" mkfs.ext4
>  _require_command "$E2FSCK_PROG" e2fsck
> -- 
> 2.43.0
>
Anand Jain Nov. 14, 2024, 9:56 a.m. UTC | #2
Reviewed-by: Anand Jain <anand.jain@oracle.com>



On 11/11/24 20:24, Johannes Thumshirn wrote:
> Test-case btrfs/136 requires ext3 support, so check for ext3 using
> _require_extra_fs.
> 
> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
> ---
>   tests/btrfs/136 | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/tests/btrfs/136 b/tests/btrfs/136
> index 9b5b3331119f..2a5280fb9bd1 100755
> --- a/tests/btrfs/136
> +++ b/tests/btrfs/136
> @@ -20,6 +20,8 @@ _require_scratch_nocheck
>   # ext4 does not support zoned block device
>   _require_non_zoned_device "${SCRATCH_DEV}"
>   
> +_require_extra_fs ext3
> +
>   _require_command "$BTRFS_CONVERT_PROG" btrfs-convert
>   _require_command "$MKFS_EXT4_PROG" mkfs.ext4
>   _require_command "$E2FSCK_PROG" e2fsck
diff mbox series

Patch

diff --git a/tests/btrfs/136 b/tests/btrfs/136
index 9b5b3331119f..2a5280fb9bd1 100755
--- a/tests/btrfs/136
+++ b/tests/btrfs/136
@@ -20,6 +20,8 @@  _require_scratch_nocheck
 # ext4 does not support zoned block device
 _require_non_zoned_device "${SCRATCH_DEV}"
 
+_require_extra_fs ext3
+
 _require_command "$BTRFS_CONVERT_PROG" btrfs-convert
 _require_command "$MKFS_EXT4_PROG" mkfs.ext4
 _require_command "$E2FSCK_PROG" e2fsck