| Message ID | 20241113225742.1784723-2-robh@kernel.org (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | [net-next] dt-bindings: net: renesas,ether: Drop undocumented "micrel,led-mode" | expand |
Hi Rob, On Wed, Nov 13, 2024 at 11:58 PM Rob Herring (Arm) <robh@kernel.org> wrote: > "micrel,led-mode" is not yet documented by a schema. It's irrelevant to Not anymore ;-) https://lore.kernel.org/943cb31d01d0da3a63911326e24fbf9b328f7206.1731580776.git.geert+renesas@glider.be > the example, so just drop it. > > Signed-off-by: Rob Herring (Arm) <robh@kernel.org> Regardless Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert
On 11/14/24 1:57 AM, Rob Herring (Arm) wrote: > "micrel,led-mode" is not yet documented by a schema. It's irrelevant to It's documented by Documentation/devicetree/bindings/net/micrel.txt... Do you mean this one should be converted to .yaml? > the example, so just drop it. > > Signed-off-by: Rob Herring (Arm) <robh@kernel.org> > --- > Documentation/devicetree/bindings/net/renesas,ether.yaml | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/net/renesas,ether.yaml b/Documentation/devicetree/bindings/net/renesas,ether.yaml > index 29355ab98569..ced1471c6484 100644 > --- a/Documentation/devicetree/bindings/net/renesas,ether.yaml > +++ b/Documentation/devicetree/bindings/net/renesas,ether.yaml > @@ -123,7 +123,6 @@ examples: > reg = <1>; > interrupt-parent = <&irqc0>; > interrupts = <0 IRQ_TYPE_LEVEL_LOW>; > - micrel,led-mode = <1>; > reset-gpios = <&gpio5 31 GPIO_ACTIVE_LOW>; > }; > }; MBR, Sergey
On Wed, Nov 13, 2024 at 04:57:42PM -0600, Rob Herring (Arm) wrote: > "micrel,led-mode" is not yet documented by a schema. It's irrelevant to > the example, so just drop it. Acked-by: Conor Dooley <conor.dooley@microchip.com>
diff --git a/Documentation/devicetree/bindings/net/renesas,ether.yaml b/Documentation/devicetree/bindings/net/renesas,ether.yaml index 29355ab98569..ced1471c6484 100644 --- a/Documentation/devicetree/bindings/net/renesas,ether.yaml +++ b/Documentation/devicetree/bindings/net/renesas,ether.yaml @@ -123,7 +123,6 @@ examples: reg = <1>; interrupt-parent = <&irqc0>; interrupts = <0 IRQ_TYPE_LEVEL_LOW>; - micrel,led-mode = <1>; reset-gpios = <&gpio5 31 GPIO_ACTIVE_LOW>; }; };
"micrel,led-mode" is not yet documented by a schema. It's irrelevant to the example, so just drop it. Signed-off-by: Rob Herring (Arm) <robh@kernel.org> --- Documentation/devicetree/bindings/net/renesas,ether.yaml | 1 - 1 file changed, 1 deletion(-)