| Message ID | 20241113130807.1386754-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | fb5e67c9d03b4a65fd43acc18cbafffff15bd8f9 |
| Headers | show |
| Series | [next] ASoC: SOF: ipc4-topology: remove redundant assignment to variable ret | expand |
On Wed, 13 Nov 2024 13:08:07 +0000, Colin Ian King wrote: > The variable ret is being assigned a zero value however the value is > never read because ret is being re-assigned later after the end of > the switch statement. The assignment is redundant and can be removed. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: SOF: ipc4-topology: remove redundant assignment to variable ret commit: fb5e67c9d03b4a65fd43acc18cbafffff15bd8f9 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/sound/soc/sof/ipc4-topology.c b/sound/soc/sof/ipc4-topology.c index 1fcf4692a21f..b55eb977e443 100644 --- a/sound/soc/sof/ipc4-topology.c +++ b/sound/soc/sof/ipc4-topology.c @@ -755,7 +755,6 @@ static int sof_ipc4_widget_setup_comp_dai(struct snd_sof_widget *swidget) * It is fine to call kfree(ipc4_copier->copier_config) since * ipc4_copier->copier_config is null. */ - ret = 0; break; }
The variable ret is being assigned a zero value however the value is never read because ret is being re-assigned later after the end of the switch statement. The assignment is redundant and can be removed. Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- sound/soc/sof/ipc4-topology.c | 1 - 1 file changed, 1 deletion(-)