| Message ID | 2373563.ElGaqSPkdT@rjwysocki.net (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v1] ACPI: processor_idle: Use acpi_idle_play_dead() for all C-states | expand |
On 11/14/2024 11:47, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > Notice that acpi_processor_setup_cstates() can set state->enter_dead to acpi_idle_play_dead() for all C-states unconditionally and remove the > confusing C-state type check done before setting it. > > No intentional functional impact. > > Suggested-by: Peter Zijlstra <peterz@infradead.org> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com> Tested-by: Mario Limonciello <mario.limonciello@amd.com> # 6.12-rc7 > --- > drivers/acpi/processor_idle.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > Index: linux-pm/drivers/acpi/processor_idle.c > =================================================================== > --- linux-pm.orig/drivers/acpi/processor_idle.c > +++ linux-pm/drivers/acpi/processor_idle.c > @@ -803,12 +803,12 @@ static int acpi_processor_setup_cstates( > state->enter = acpi_idle_enter; > > state->flags = 0; > - if (cx->type == ACPI_STATE_C1 || cx->type == ACPI_STATE_C2 || > - cx->type == ACPI_STATE_C3) { > - state->enter_dead = acpi_idle_play_dead; > - if (cx->type != ACPI_STATE_C3) > - drv->safe_state_index = count; > - } > + > + state->enter_dead = acpi_idle_play_dead; > + > + if (cx->type == ACPI_STATE_C1 || cx->type == ACPI_STATE_C2) > + drv->safe_state_index = count; > + > /* > * Halt-induced C1 is not good for ->enter_s2idle, because it > * re-enables interrupts on exit. Moreover, C1 is generally not > > >
On Thu, Nov 14, 2024 at 06:47:55PM +0100, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > Notice that acpi_processor_setup_cstates() can set state->enter_dead to acpi_idle_play_dead() for all C-states unconditionally and remove the > confusing C-state type check done before setting it. > > No intentional functional impact. > > Suggested-by: Peter Zijlstra <peterz@infradead.org> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > --- > drivers/acpi/processor_idle.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > Index: linux-pm/drivers/acpi/processor_idle.c > =================================================================== > --- linux-pm.orig/drivers/acpi/processor_idle.c > +++ linux-pm/drivers/acpi/processor_idle.c > @@ -803,12 +803,12 @@ static int acpi_processor_setup_cstates( > state->enter = acpi_idle_enter; > > state->flags = 0; > - if (cx->type == ACPI_STATE_C1 || cx->type == ACPI_STATE_C2 || > - cx->type == ACPI_STATE_C3) { > - state->enter_dead = acpi_idle_play_dead; > - if (cx->type != ACPI_STATE_C3) > - drv->safe_state_index = count; > - } > + > + state->enter_dead = acpi_idle_play_dead; > + > + if (cx->type == ACPI_STATE_C1 || cx->type == ACPI_STATE_C2) > + drv->safe_state_index = count; > + Thanks! Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Index: linux-pm/drivers/acpi/processor_idle.c =================================================================== --- linux-pm.orig/drivers/acpi/processor_idle.c +++ linux-pm/drivers/acpi/processor_idle.c @@ -803,12 +803,12 @@ static int acpi_processor_setup_cstates( state->enter = acpi_idle_enter; state->flags = 0; - if (cx->type == ACPI_STATE_C1 || cx->type == ACPI_STATE_C2 || - cx->type == ACPI_STATE_C3) { - state->enter_dead = acpi_idle_play_dead; - if (cx->type != ACPI_STATE_C3) - drv->safe_state_index = count; - } + + state->enter_dead = acpi_idle_play_dead; + + if (cx->type == ACPI_STATE_C1 || cx->type == ACPI_STATE_C2) + drv->safe_state_index = count; + /* * Halt-induced C1 is not good for ->enter_s2idle, because it * re-enables interrupts on exit. Moreover, C1 is generally not