| Message ID | 20241118-b4-max17042-v3-1-9bcaeda42a06@gmail.com (mailing list archive) |
|---|---|
| State | Handled Elsewhere, archived |
| Headers | show |
| Series | power: supply: max17042: cleanup and more features | expand |
Hi Dzmitry, On 18-Nov-24 11:09 AM, Dzmitry Sankouski wrote: > Fuelgauge blocks often are incorporated in bigger chip, > which may use only 1 line for interrupts. Make interrupt > shared. > > Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com> Thanks, patch looks good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans > --- > drivers/power/supply/max17042_battery.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/drivers/power/supply/max17042_battery.c b/drivers/power/supply/max17042_battery.c > index 496c3e1f2ee6..99bf6915aa23 100644 > --- a/drivers/power/supply/max17042_battery.c > +++ b/drivers/power/supply/max17042_battery.c > @@ -1103,14 +1103,7 @@ static int max17042_probe(struct i2c_client *client) > } > > if (client->irq) { > - unsigned int flags = IRQF_ONESHOT; > - > - /* > - * On ACPI systems the IRQ may be handled by ACPI-event code, > - * so we need to share (if the ACPI code is willing to share). > - */ > - if (acpi_id) > - flags |= IRQF_SHARED | IRQF_PROBE_SHARED; > + unsigned int flags = IRQF_ONESHOT | IRQF_SHARED | IRQF_PROBE_SHARED; > > ret = devm_request_threaded_irq(&client->dev, client->irq, > NULL, >
diff --git a/drivers/power/supply/max17042_battery.c b/drivers/power/supply/max17042_battery.c index 496c3e1f2ee6..99bf6915aa23 100644 --- a/drivers/power/supply/max17042_battery.c +++ b/drivers/power/supply/max17042_battery.c @@ -1103,14 +1103,7 @@ static int max17042_probe(struct i2c_client *client) } if (client->irq) { - unsigned int flags = IRQF_ONESHOT; - - /* - * On ACPI systems the IRQ may be handled by ACPI-event code, - * so we need to share (if the ACPI code is willing to share). - */ - if (acpi_id) - flags |= IRQF_SHARED | IRQF_PROBE_SHARED; + unsigned int flags = IRQF_ONESHOT | IRQF_SHARED | IRQF_PROBE_SHARED; ret = devm_request_threaded_irq(&client->dev, client->irq, NULL,
Fuelgauge blocks often are incorporated in bigger chip, which may use only 1 line for interrupts. Make interrupt shared. Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com> --- drivers/power/supply/max17042_battery.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-)