| Message ID | 20241118105145.2329902-1-andrew.cooper3@citrix.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | xen/bootinfo: Include declaration for fw_unreserved_regions() | expand |
On Mon, 18 Nov 2024, Andrew Cooper wrote: > Eclair complains that fw_unreserved_regions() can't see it's declaration. > Include <asm/setup.h> to address this. > > This makes Mira Rule 8.4 clean on ARM, so tag it as such. > > Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> Very nice! Thank you! Reviewed-by: Stefano Stabellini <sstabellini@kernel.org> > --- > CC: Jan Beulich <JBeulich@suse.com> > CC: Stefano Stabellini <sstabellini@kernel.org> > CC: Julien Grall <julien@xen.org> > CC: consulting@bugseng.com <consulting@bugseng.com> > > https://gitlab.com/xen-project/people/andyhhp/xen/-/pipelines/1547057124 > --- > automation/eclair_analysis/ECLAIR/tagging.ecl | 2 +- > xen/common/device-tree/bootinfo.c | 2 ++ > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/automation/eclair_analysis/ECLAIR/tagging.ecl b/automation/eclair_analysis/ECLAIR/tagging.ecl > index 9318e5b10ca8..7944ce2ee3b2 100644 > --- a/automation/eclair_analysis/ECLAIR/tagging.ecl > +++ b/automation/eclair_analysis/ECLAIR/tagging.ecl > @@ -115,7 +115,7 @@ if(string_equal(target,"x86_64"), > ) > > if(string_equal(target,"arm64"), > - service_selector({"additional_clean_guidelines","MC3R1.R2.1||MC3R1.R5.3||MC3.R11.2||MC3R1.R16.6||MC3R1.R20.7"}) > + service_selector({"additional_clean_guidelines","MC3R1.R2.1||MC3R1.R5.3||MC3R1.R8.4||MC3.R11.2||MC3R1.R16.6||MC3R1.R20.7"}) > ) > > -reports+={clean:added,"service(clean_guidelines_common||additional_clean_guidelines)"} > diff --git a/xen/common/device-tree/bootinfo.c b/xen/common/device-tree/bootinfo.c > index f2e6a1145b7c..3738eb57ff52 100644 > --- a/xen/common/device-tree/bootinfo.c > +++ b/xen/common/device-tree/bootinfo.c > @@ -17,6 +17,8 @@ > #include <xen/libfdt/libfdt-xen.h> > #include <xen/mm.h> > > +#include <asm/setup.h> > + > struct bootinfo __initdata bootinfo = BOOTINFO_INIT; > > const char * __init boot_module_kind_as_string(bootmodule_kind kind) > > base-commit: 88c40dc108bfddb32a891e2e20d48bbe94949200 > -- > 2.39.5 >
diff --git a/automation/eclair_analysis/ECLAIR/tagging.ecl b/automation/eclair_analysis/ECLAIR/tagging.ecl index 9318e5b10ca8..7944ce2ee3b2 100644 --- a/automation/eclair_analysis/ECLAIR/tagging.ecl +++ b/automation/eclair_analysis/ECLAIR/tagging.ecl @@ -115,7 +115,7 @@ if(string_equal(target,"x86_64"), ) if(string_equal(target,"arm64"), - service_selector({"additional_clean_guidelines","MC3R1.R2.1||MC3R1.R5.3||MC3.R11.2||MC3R1.R16.6||MC3R1.R20.7"}) + service_selector({"additional_clean_guidelines","MC3R1.R2.1||MC3R1.R5.3||MC3R1.R8.4||MC3.R11.2||MC3R1.R16.6||MC3R1.R20.7"}) ) -reports+={clean:added,"service(clean_guidelines_common||additional_clean_guidelines)"} diff --git a/xen/common/device-tree/bootinfo.c b/xen/common/device-tree/bootinfo.c index f2e6a1145b7c..3738eb57ff52 100644 --- a/xen/common/device-tree/bootinfo.c +++ b/xen/common/device-tree/bootinfo.c @@ -17,6 +17,8 @@ #include <xen/libfdt/libfdt-xen.h> #include <xen/mm.h> +#include <asm/setup.h> + struct bootinfo __initdata bootinfo = BOOTINFO_INIT; const char * __init boot_module_kind_as_string(bootmodule_kind kind)
Eclair complains that fw_unreserved_regions() can't see it's declaration. Include <asm/setup.h> to address this. This makes Mira Rule 8.4 clean on ARM, so tag it as such. Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> --- CC: Jan Beulich <JBeulich@suse.com> CC: Stefano Stabellini <sstabellini@kernel.org> CC: Julien Grall <julien@xen.org> CC: consulting@bugseng.com <consulting@bugseng.com> https://gitlab.com/xen-project/people/andyhhp/xen/-/pipelines/1547057124 --- automation/eclair_analysis/ECLAIR/tagging.ecl | 2 +- xen/common/device-tree/bootinfo.c | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) base-commit: 88c40dc108bfddb32a891e2e20d48bbe94949200