[0/2] KVM: x86: Fix more KVM_X86 Kconfig bugs

Message

Sean Christopherson Nov. 18, 2024, 5:20 p.m. UTC

Fix two more bugs in the KVM_X86 Kconfig.  The fix from Arnd resolves a
build failure, but practically speaking is a non-issue because the failure
only affects 32-bit !SMP builds that effectively disable the local APIC.

The second fix is far more urgent.  It resolves a bug where KVM's Kconfig
doesn't correctly define KVM_X86, and will build kvm.ko as a module when
KVM=y if neither KVM_INTEL nor KVM_AMD is 'y', e.g. if KVM=y, KVM_INTEL,=m,
and KVM_AMD=m.  I don't know if any distros use that combo, but it broke
our production kernel, so it's certainly possible that it broke other
setups too.

Arnd's fix was already posted, but I bundled it here to avoid a trivial
conflict and to ensure it doesn't get left behind.

Arnd Bergmann (1):
  KVM: x86: add back X86_LOCAL_APIC dependency

Sean Christopherson (1):
  KVM: x86: Break CONFIG_KVM_X86's direct dependency on KVM_INTEL ||
    KVM_AMD

 arch/x86/kvm/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


base-commit: adc218676eef25575469234709c2d87185ca223a

Comments

Paolo Bonzini Nov. 20, 2024, 12:35 a.m. UTC | #1

Queued, thanks.

Paolo