| Message ID | 20241119-b4-linux-next-24-11-18-dtsi-x1e80100-camss-v1-3-54075d75f654@linaro.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Add dt-bindings and dtsi changes for CAMSS on x1e80100 silicon | expand |
On 11/19/24 15:10, Bryan O'Donoghue wrote: > The x1e80100 has two power-domains for the CAMCC not one. > > Capture this as: > minItems:1 > maxItems:2 > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > --- > Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml > index 0766f66c7dc4f6b81afa01f156c490f4f742fcee..afb7e37118b691658fc5cc71e97b110dcee7f22a 100644 > --- a/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml > +++ b/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml > @@ -39,9 +39,10 @@ properties: > - description: Sleep clock source > > power-domains: > - maxItems: 1 > + minItems: 1 > + maxItems: 2 > description: > - A phandle and PM domain specifier for the MMCX power domain. > + A phandle and PM domain specifier for the MMCX or MCX power domains. It's a list of two phandles, not a one or another one. Can you please > > required-opps: > maxItems: 1 > Apart of the review comment above to be resolved, Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org> -- Best wishes, Vladimir
On 19/11/2024 14:47, Vladimir Zapolskiy wrote: >> + maxItems: 2 >> description: >> - A phandle and PM domain specifier for the MMCX power domain. >> + A phandle and PM domain specifier for the MMCX or MCX power >> domains. > > It's a list of two phandles, not a one or another one. Can you please Its two for x1e80100 or one for sm8450. I'll find a way to express this more clearly. --- bod
On Tue, Nov 19, 2024 at 01:10:32PM +0000, Bryan O'Donoghue wrote: > The x1e80100 has two power-domains for the CAMCC not one. > > Capture this as: > minItems:1 > maxItems:2 > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > --- > Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml > index 0766f66c7dc4f6b81afa01f156c490f4f742fcee..afb7e37118b691658fc5cc71e97b110dcee7f22a 100644 > --- a/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml > +++ b/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml > @@ -39,9 +39,10 @@ properties: > - description: Sleep clock source > > power-domains: > - maxItems: 1 > + minItems: 1 > + maxItems: 2 > description: > - A phandle and PM domain specifier for the MMCX power domain. > + A phandle and PM domain specifier for the MMCX or MCX power domains. > Instead list the items with description and minItems minItems: 1 items: - description: - description: also add in allOf section if:then: constraining it for all variants (maxItems: 1 and minItems: 2). Optionally X1E could be moved to a new binding. I think this would be better, but I do not insist. Best regards, Krzysztof
On Tue, Nov 19, 2024 at 01:10:32PM +0000, Bryan O'Donoghue wrote: > The x1e80100 has two power-domains for the CAMCC not one. > > Capture this as: > minItems:1 > maxItems:2 > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > --- > Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml > index 0766f66c7dc4f6b81afa01f156c490f4f742fcee..afb7e37118b691658fc5cc71e97b110dcee7f22a 100644 > --- a/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml > +++ b/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml > @@ -39,9 +39,10 @@ properties: > - description: Sleep clock source > > power-domains: > - maxItems: 1 > + minItems: 1 > + maxItems: 2 > description: > - A phandle and PM domain specifier for the MMCX power domain. > + A phandle and PM domain specifier for the MMCX or MCX power domains. Should there be an if, selecting which platforms need 1 domain and which need both? > > required-opps: > maxItems: 1 > > -- > 2.45.2 >
diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml index 0766f66c7dc4f6b81afa01f156c490f4f742fcee..afb7e37118b691658fc5cc71e97b110dcee7f22a 100644 --- a/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml +++ b/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml @@ -39,9 +39,10 @@ properties: - description: Sleep clock source power-domains: - maxItems: 1 + minItems: 1 + maxItems: 2 description: - A phandle and PM domain specifier for the MMCX power domain. + A phandle and PM domain specifier for the MMCX or MCX power domains. required-opps: maxItems: 1
The x1e80100 has two power-domains for the CAMCC not one. Capture this as: minItems:1 maxItems:2 Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> --- Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)