[v2,0/2] chardev/char-mux: tweak mux bitset operations

Message

Roman Penyaev Nov. 20, 2024, 7:53 a.m. UTC

Patchset tweaks bitset operations by changing a constant to unsigned
long, introduces a static compile check and simplifies bitset operations.

v1..v2:

Rebase on latest master, incorporate review tags.

Roman Penyaev (2):
  chardev/char-mux: shift unsigned long to avoid 32-bit overflow
  chardev/char-mux: make boolean bit check instead of find_next_bit()

 chardev/char-mux.c | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)


Signed-off-by: Roman Penyaev <[e-mail]>
Reviewed-by: "Marc-André Lureau" <[e-mail]>
Cc: Peter Maydell <[e-mail]>
Reviewed-by: Clément Mathieu--Drif <[e-mail]>
Cc: [e-mail]

Comments

Paolo Bonzini Nov. 20, 2024, 2:44 p.m. UTC | #1

Queued, with just one change:

> Also add a static compile check that MAX_MUX never bigger than
> `sizeof(d->mux_bitset)`.

This needs to be multiplied by CHAR_BIT.

Paolo

On 11/20/24 08:53, Roman Penyaev wrote:
> Patchset tweaks bitset operations by changing a constant to unsigned
> long, introduces a static compile check and simplifies bitset operations.
> 
> v1..v2:
> 
> Rebase on latest master, incorporate review tags.
> 
> Roman Penyaev (2):
>    chardev/char-mux: shift unsigned long to avoid 32-bit overflow
>    chardev/char-mux: make boolean bit check instead of find_next_bit()
> 
>   chardev/char-mux.c | 15 +++++++--------
>   1 file changed, 7 insertions(+), 8 deletions(-)
> 
> 
> Signed-off-by: Roman Penyaev <[e-mail]>
> Reviewed-by: "Marc-André Lureau" <[e-mail]>
> Cc: Peter Maydell <[e-mail]>
> Reviewed-by: Clément Mathieu--Drif <[e-mail]>
> Cc: [e-mail]
> 
>