diff mbox series

drm: renesas: rz-du: Increase supported resolutions

Message ID 20241120150328.4131525-1-chris.brandt@renesas.com (mailing list archive)
State New
Delegated to: Kieran Bingham
Headers show
Series drm: renesas: rz-du: Increase supported resolutions | expand

Commit Message

Chris Brandt Nov. 20, 2024, 3:03 p.m. UTC
The supported resolutions were misrepresented in earlier versions of
hardware manuals.

Fixes: 768e9e61b3b9 ("drm: renesas: Add RZ/G2L DU Support")
Cc: stable@vger.kernel.org
Signed-off-by: Chris Brandt <chris.brandt@renesas.com>
---
 drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Hugo Villeneuve Nov. 20, 2024, 3:57 p.m. UTC | #1
Hi,

On Wed, 20 Nov 2024 10:03:28 -0500
Chris Brandt <chris.brandt@renesas.com> wrote:

> The supported resolutions were misrepresented in earlier versions of
> hardware manuals.
> 
> Fixes: 768e9e61b3b9 ("drm: renesas: Add RZ/G2L DU Support")
> Cc: stable@vger.kernel.org
> Signed-off-by: Chris Brandt <chris.brandt@renesas.com>

Tested on a custom RZ/G2LC board with two different display panels
of 600x1600 and 440x1920 resolutions in portrait mode.

Tested-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>

> ---
>  drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.c b/drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.c
> index b99217b4e05d..90c6269ccd29 100644
> --- a/drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.c
> +++ b/drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.c
> @@ -311,11 +311,11 @@ int rzg2l_du_modeset_init(struct rzg2l_du_device *rcdu)
>  	dev->mode_config.helper_private = &rzg2l_du_mode_config_helper;
>  
>  	/*
> -	 * The RZ DU uses the VSP1 for memory access, and is limited
> -	 * to frame sizes of 1920x1080.
> +	 * The RZ DU was designed to support a frame size of 1920x1200 (landscape)
> +	 * or 1200x1920 (portrait).
>  	 */
>  	dev->mode_config.max_width = 1920;
> -	dev->mode_config.max_height = 1080;
> +	dev->mode_config.max_height = 1920;
>  
>  	rcdu->num_crtcs = hweight8(rcdu->info->channels_mask);
>  
> -- 
> 2.34.1
>
Biju Das Nov. 21, 2024, 8:20 a.m. UTC | #2
Hi Chris Brandt,

Thanks for the patch.

> -----Original Message-----
> From: Chris Brandt <chris.brandt@renesas.com>
> Sent: 20 November 2024 15:03
> Subject: [PATCH] drm: renesas: rz-du: Increase supported resolutions
> 
> The supported resolutions were misrepresented in earlier versions of hardware manuals.
> 
> Fixes: 768e9e61b3b9 ("drm: renesas: Add RZ/G2L DU Support")
> Cc: stable@vger.kernel.org
> Signed-off-by: Chris Brandt <chris.brandt@renesas.com>

Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>

Cheers,
Biju

> ---
>  drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.c b/drivers/gpu/drm/renesas/rz-
> du/rzg2l_du_kms.c
> index b99217b4e05d..90c6269ccd29 100644
> --- a/drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.c
> +++ b/drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.c
> @@ -311,11 +311,11 @@ int rzg2l_du_modeset_init(struct rzg2l_du_device *rcdu)
>  	dev->mode_config.helper_private = &rzg2l_du_mode_config_helper;
> 
>  	/*
> -	 * The RZ DU uses the VSP1 for memory access, and is limited
> -	 * to frame sizes of 1920x1080.
> +	 * The RZ DU was designed to support a frame size of 1920x1200 (landscape)
> +	 * or 1200x1920 (portrait).
>  	 */
>  	dev->mode_config.max_width = 1920;
> -	dev->mode_config.max_height = 1080;
> +	dev->mode_config.max_height = 1920;
> 
>  	rcdu->num_crtcs = hweight8(rcdu->info->channels_mask);
> 
> --
> 2.34.1
diff mbox series

Patch

diff --git a/drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.c b/drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.c
index b99217b4e05d..90c6269ccd29 100644
--- a/drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.c
+++ b/drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.c
@@ -311,11 +311,11 @@  int rzg2l_du_modeset_init(struct rzg2l_du_device *rcdu)
 	dev->mode_config.helper_private = &rzg2l_du_mode_config_helper;
 
 	/*
-	 * The RZ DU uses the VSP1 for memory access, and is limited
-	 * to frame sizes of 1920x1080.
+	 * The RZ DU was designed to support a frame size of 1920x1200 (landscape)
+	 * or 1200x1920 (portrait).
 	 */
 	dev->mode_config.max_width = 1920;
-	dev->mode_config.max_height = 1080;
+	dev->mode_config.max_height = 1920;
 
 	rcdu->num_crtcs = hweight8(rcdu->info->channels_mask);