| Message ID | Zz4R8L7493vTJmry@rasomin (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | staging: sm750fb: Remove unnecessary parentheses | expand |
On Wed, Nov 20, 2024 at 04:44:39PM +0000, Cheolu Choi wrote: > Adhere to Linux kernel coding style. > > Reported by checkpatch: > CHECK: Unnecessary parentheses around 'clk_gpio > 31' > CHECK: Unnecessary parentheses around 'data_gpio > 31' > > Signed-off-by: Cheolu Choi <ray@rasom.in> > --- > drivers/staging/sm750fb/ddk750_swi2c.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/sm750fb/ddk750_swi2c.c b/drivers/staging/sm750fb/ddk750_swi2c.c > index 0ef8d4ff2ef9..50e51d730d86 100644 > --- a/drivers/staging/sm750fb/ddk750_swi2c.c > +++ b/drivers/staging/sm750fb/ddk750_swi2c.c > @@ -393,7 +393,7 @@ long sm750_sw_i2c_init(unsigned char clk_gpio, unsigned char data_gpio) > * Return 0 if the GPIO pins to be used is out of range. The > * range is only from [0..63] > */ > - if ((clk_gpio > 31) || (data_gpio > 31)) > + if (clk_gpio > 31 || data_gpio > 31) > return -1; > > if (sm750_get_chip_type() == SM750LE) > -- > 2.34.1 > > > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - You sent a patch that has been sent multiple times in the past, days, and is almost identical to ones that have been rejected. Please always look at the mailing list traffic to determine if you are duplicating other people's work. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot
diff --git a/drivers/staging/sm750fb/ddk750_swi2c.c b/drivers/staging/sm750fb/ddk750_swi2c.c index 0ef8d4ff2ef9..50e51d730d86 100644 --- a/drivers/staging/sm750fb/ddk750_swi2c.c +++ b/drivers/staging/sm750fb/ddk750_swi2c.c @@ -393,7 +393,7 @@ long sm750_sw_i2c_init(unsigned char clk_gpio, unsigned char data_gpio) * Return 0 if the GPIO pins to be used is out of range. The * range is only from [0..63] */ - if ((clk_gpio > 31) || (data_gpio > 31)) + if (clk_gpio > 31 || data_gpio > 31) return -1; if (sm750_get_chip_type() == SM750LE)
Adhere to Linux kernel coding style. Reported by checkpatch: CHECK: Unnecessary parentheses around 'clk_gpio > 31' CHECK: Unnecessary parentheses around 'data_gpio > 31' Signed-off-by: Cheolu Choi <ray@rasom.in> --- drivers/staging/sm750fb/ddk750_swi2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)