| Message ID | 20241120204125.52644-1-pvorel@suse.cz (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v4,1/2] init/Kconfig: add python3 availability config | expand |
On Thu, Nov 21, 2024 at 5:41 AM Petr Vorel <pvorel@suse.cz> wrote: > > It will be used in the next commit for DRM_MSM. > > Suggested-by: Rob Clark <robdclark@gmail.com> > Signed-off-by: Petr Vorel <pvorel@suse.cz> > --- > Changes v3->v4: > * Move definition to the end of the file I prefer to not check the tool. Why don't you install python3? > init/Kconfig | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/init/Kconfig b/init/Kconfig > index fbd0cb06a50a..c77e45484e81 100644 > --- a/init/Kconfig > +++ b/init/Kconfig > @@ -2047,3 +2047,6 @@ config ARCH_HAS_SYNC_CORE_BEFORE_USERMODE > # <asm/syscall_wrapper.h>. > config ARCH_HAS_SYSCALL_WRAPPER > def_bool n > + > +config HAVE_PYTHON3 > + def_bool $(success,$(PYTHON3) -V) > -- > 2.45.2 >
> On Thu, Nov 21, 2024 at 5:41 AM Petr Vorel <pvorel@suse.cz> wrote: > > It will be used in the next commit for DRM_MSM. > > Suggested-by: Rob Clark <robdclark@gmail.com> > > Signed-off-by: Petr Vorel <pvorel@suse.cz> > > --- > > Changes v3->v4: > > * Move definition to the end of the file > I prefer to not check the tool. Ack. > Why don't you install python3? Everybody installs it when it's required, the question is how to inform about the dependency. There build environments are minimal environments: * chroot (e.g. cross compilation) * container These are used by both developers and distros. Kind regards, Petr > > init/Kconfig | 3 +++ > > 1 file changed, 3 insertions(+) > > diff --git a/init/Kconfig b/init/Kconfig > > index fbd0cb06a50a..c77e45484e81 100644 > > --- a/init/Kconfig > > +++ b/init/Kconfig > > @@ -2047,3 +2047,6 @@ config ARCH_HAS_SYNC_CORE_BEFORE_USERMODE > > # <asm/syscall_wrapper.h>. > > config ARCH_HAS_SYSCALL_WRAPPER > > def_bool n > > + > > +config HAVE_PYTHON3 > > + def_bool $(success,$(PYTHON3) -V) > > -- > > 2.45.2
On Wed, Nov 20, 2024 at 5:17 PM Petr Vorel <pvorel@suse.cz> wrote: > > > On Thu, Nov 21, 2024 at 5:41 AM Petr Vorel <pvorel@suse.cz> wrote: > > > > It will be used in the next commit for DRM_MSM. > > > > Suggested-by: Rob Clark <robdclark@gmail.com> > > > Signed-off-by: Petr Vorel <pvorel@suse.cz> > > > --- > > > Changes v3->v4: > > > * Move definition to the end of the file > > > > I prefer to not check the tool. > > Ack. > > > Why don't you install python3? > > Everybody installs it when it's required, the question is how to inform about > the dependency. > > There build environments are minimal environments: > * chroot (e.g. cross compilation) > * container > > These are used by both developers and distros. I don't think py3 is an _onerous_ dependency, but it has come up as a surprise in minimal distro build environments at least once.. so I'd be a fan of surfacing this dependency in a predictable/understandable way (ie. I'm in favor of this patchset) BR, -R > Kind regards, > Petr > > > > init/Kconfig | 3 +++ > > > 1 file changed, 3 insertions(+) > > > > diff --git a/init/Kconfig b/init/Kconfig > > > index fbd0cb06a50a..c77e45484e81 100644 > > > --- a/init/Kconfig > > > +++ b/init/Kconfig > > > @@ -2047,3 +2047,6 @@ config ARCH_HAS_SYNC_CORE_BEFORE_USERMODE > > > # <asm/syscall_wrapper.h>. > > > config ARCH_HAS_SYSCALL_WRAPPER > > > def_bool n > > > + > > > +config HAVE_PYTHON3 > > > + def_bool $(success,$(PYTHON3) -V) > > > -- > > > 2.45.2
diff --git a/init/Kconfig b/init/Kconfig index fbd0cb06a50a..c77e45484e81 100644 --- a/init/Kconfig +++ b/init/Kconfig @@ -2047,3 +2047,6 @@ config ARCH_HAS_SYNC_CORE_BEFORE_USERMODE # <asm/syscall_wrapper.h>. config ARCH_HAS_SYSCALL_WRAPPER def_bool n + +config HAVE_PYTHON3 + def_bool $(success,$(PYTHON3) -V)
It will be used in the next commit for DRM_MSM. Suggested-by: Rob Clark <robdclark@gmail.com> Signed-off-by: Petr Vorel <pvorel@suse.cz> --- Changes v3->v4: * Move definition to the end of the file init/Kconfig | 3 +++ 1 file changed, 3 insertions(+)