diff mbox series

media: ov5640: fix get_light_freq on auto

Message ID cb9f8aca1f07472d4c794cc66ebbde1977ee9e95.1732195934.git.michal.simek@amd.com (mailing list archive)
State New
Headers show
Series media: ov5640: fix get_light_freq on auto | expand

Commit Message

Michal Simek Nov. 21, 2024, 1:32 p.m. UTC
From: Sam Bobrowicz <sam@elite-embedded.com>

Light frequency was not properly returned when in auto
mode and the detected frequency was 60Hz.

Signed-off-by: Sam Bobrowicz <sam@elite-embedded.com>
Signed-off-by: Michal Simek <michal.simek@amd.com>
---

 drivers/media/i2c/ov5640.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Sakari Ailus Nov. 21, 2024, 1:35 p.m. UTC | #1
Hi Michal,

On Thu, Nov 21, 2024 at 02:32:16PM +0100, Michal Simek wrote:
> From: Sam Bobrowicz <sam@elite-embedded.com>
> 
> Light frequency was not properly returned when in auto
> mode and the detected frequency was 60Hz.
> 
> Signed-off-by: Sam Bobrowicz <sam@elite-embedded.com>
> Signed-off-by: Michal Simek <michal.simek@amd.com>
> ---
> 
>  drivers/media/i2c/ov5640.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c
> index c1d3fce4a7d3..8566bc2edde9 100644
> --- a/drivers/media/i2c/ov5640.c
> +++ b/drivers/media/i2c/ov5640.c
> @@ -1982,6 +1982,7 @@ static int ov5640_get_light_freq(struct ov5640_dev *sensor)
>  			light_freq = 50;
>  		} else {
>  			/* 60Hz */
> +			light_freq = 60;

Any idea where this issue was introduced?

It'd be good to add Fixes: and Cc: stable to this.

>  		}
>  	}
>
diff mbox series

Patch

diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c
index c1d3fce4a7d3..8566bc2edde9 100644
--- a/drivers/media/i2c/ov5640.c
+++ b/drivers/media/i2c/ov5640.c
@@ -1982,6 +1982,7 @@  static int ov5640_get_light_freq(struct ov5640_dev *sensor)
 			light_freq = 50;
 		} else {
 			/* 60Hz */
+			light_freq = 60;
 		}
 	}