| Message ID | 20241122113322.242875-17-u.kleine-koenig@baylibre.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | iio: adc: ad7124: Various fixes | expand |
On 2024-11-22 06:33, Uwe Kleine-König wrote: > When struct ad_sigma_delta::keep_cs_asserted was introduced only > register writing was adapted to honor this new flag. Also respect it > when reading a register. > > Fixes: df1d80aee963 ("iio: ad_sigma_delta: Properly handle SPI bus locking vs CS assertion") > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com> Reviewed-by: Trevor Gamblin <tgamblin@baylibre.com>
Hello Trevor, On Fri, Nov 22, 2024 at 10:16:07AM -0500, Trevor Gamblin wrote: > On 2024-11-22 06:33, Uwe Kleine-König wrote: > > When struct ad_sigma_delta::keep_cs_asserted was introduced only > > register writing was adapted to honor this new flag. Also respect it > > when reading a register. > > > > Fixes: df1d80aee963 ("iio: ad_sigma_delta: Properly handle SPI bus locking vs CS assertion") > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com> > Reviewed-by: Trevor Gamblin <tgamblin@baylibre.com> Oh, you already provided your Reviewed-by tag on the initial submission. Sorry to have missed to add it myself and thanks to have provided it again. Uwe
diff --git a/drivers/iio/adc/ad_sigma_delta.c b/drivers/iio/adc/ad_sigma_delta.c index 4c8d986b6609..5e7e5cb908d8 100644 --- a/drivers/iio/adc/ad_sigma_delta.c +++ b/drivers/iio/adc/ad_sigma_delta.c @@ -109,7 +109,7 @@ static int ad_sd_read_reg_raw(struct ad_sigma_delta *sigma_delta, }, { .rx_buf = val, .len = size, - .cs_change = sigma_delta->bus_locked, + .cs_change = sigma_delta->keep_cs_asserted, }, }; struct spi_message m;
When struct ad_sigma_delta::keep_cs_asserted was introduced only register writing was adapted to honor this new flag. Also respect it when reading a register. Fixes: df1d80aee963 ("iio: ad_sigma_delta: Properly handle SPI bus locking vs CS assertion") Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com> --- drivers/iio/adc/ad_sigma_delta.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)