| Message ID | 20241118164434.7551-12-alejandro.lucero-palau@amd.com |
|---|---|
| State | New |
| Headers | show |
| Series | cxl: add type2 device basic support | expand |
On 11/18/24 9:44 AM, alejandro.lucero-palau@amd.com wrote: > From: Alejandro Lucero <alucerop@amd.com> > > A Type-2 driver can require to set the memory availability explicitly. > > Add a function to the exported CXL API for accelerator drivers. > > Signed-off-by: Alejandro Lucero <alucerop@amd.com> Reviewed-by: Dave Jiang <dave.jiang@intel.com> > --- > drivers/cxl/core/memdev.c | 6 ++++++ > include/cxl/cxl.h | 1 + > 2 files changed, 7 insertions(+) > > diff --git a/drivers/cxl/core/memdev.c b/drivers/cxl/core/memdev.c > index 7450172c1864..d746c8a1021c 100644 > --- a/drivers/cxl/core/memdev.c > +++ b/drivers/cxl/core/memdev.c > @@ -795,6 +795,12 @@ int cxl_release_resource(struct cxl_dev_state *cxlds, enum cxl_resource type) > } > EXPORT_SYMBOL_NS_GPL(cxl_release_resource, CXL); > > +void cxl_set_media_ready(struct cxl_dev_state *cxlds) > +{ > + cxlds->media_ready = true; > +} > +EXPORT_SYMBOL_NS_GPL(cxl_set_media_ready, CXL); > + > static int cxl_memdev_release_file(struct inode *inode, struct file *file) > { > struct cxl_memdev *cxlmd = > diff --git a/include/cxl/cxl.h b/include/cxl/cxl.h > index e0bafd066b93..6033ce84b3d3 100644 > --- a/include/cxl/cxl.h > +++ b/include/cxl/cxl.h > @@ -56,4 +56,5 @@ bool cxl_pci_check_caps(struct cxl_dev_state *cxlds, > int cxl_pci_accel_setup_regs(struct pci_dev *pdev, struct cxl_dev_state *cxlds); > int cxl_request_resource(struct cxl_dev_state *cxlds, enum cxl_resource type); > int cxl_release_resource(struct cxl_dev_state *cxlds, enum cxl_resource type); > +void cxl_set_media_ready(struct cxl_dev_state *cxlds); > #endif
On 11/18/24 10:44 AM, alejandro.lucero-palau@amd.com wrote: > From: Alejandro Lucero <alucerop@amd.com> > > A Type-2 driver can require to set the memory availability explicitly. Little grammar nit, I think "may be required" reads better. I would also say why, for example: "... set the memory availability explicitly due to the possible lack of a mailbox". > > Add a function to the exported CXL API for accelerator drivers. > > Signed-off-by: Alejandro Lucero <alucerop@amd.com> > --- Actual patch contents LGTM, so regardless of nit above: Reviewed-by: Ben Cheatham <benjamin.cheatham@amd.com> > drivers/cxl/core/memdev.c | 6 ++++++ > include/cxl/cxl.h | 1 + > 2 files changed, 7 insertions(+) > > diff --git a/drivers/cxl/core/memdev.c b/drivers/cxl/core/memdev.c > index 7450172c1864..d746c8a1021c 100644 > --- a/drivers/cxl/core/memdev.c > +++ b/drivers/cxl/core/memdev.c > @@ -795,6 +795,12 @@ int cxl_release_resource(struct cxl_dev_state *cxlds, enum cxl_resource type) > } > EXPORT_SYMBOL_NS_GPL(cxl_release_resource, CXL); > > +void cxl_set_media_ready(struct cxl_dev_state *cxlds) > +{ > + cxlds->media_ready = true; > +} > +EXPORT_SYMBOL_NS_GPL(cxl_set_media_ready, CXL); > + > static int cxl_memdev_release_file(struct inode *inode, struct file *file) > { > struct cxl_memdev *cxlmd = > diff --git a/include/cxl/cxl.h b/include/cxl/cxl.h > index e0bafd066b93..6033ce84b3d3 100644 > --- a/include/cxl/cxl.h > +++ b/include/cxl/cxl.h > @@ -56,4 +56,5 @@ bool cxl_pci_check_caps(struct cxl_dev_state *cxlds, > int cxl_pci_accel_setup_regs(struct pci_dev *pdev, struct cxl_dev_state *cxlds); > int cxl_request_resource(struct cxl_dev_state *cxlds, enum cxl_resource type); > int cxl_release_resource(struct cxl_dev_state *cxlds, enum cxl_resource type); > +void cxl_set_media_ready(struct cxl_dev_state *cxlds); > #endif
diff --git a/drivers/cxl/core/memdev.c b/drivers/cxl/core/memdev.c index 7450172c1864..d746c8a1021c 100644 --- a/drivers/cxl/core/memdev.c +++ b/drivers/cxl/core/memdev.c @@ -795,6 +795,12 @@ int cxl_release_resource(struct cxl_dev_state *cxlds, enum cxl_resource type) } EXPORT_SYMBOL_NS_GPL(cxl_release_resource, CXL); +void cxl_set_media_ready(struct cxl_dev_state *cxlds) +{ + cxlds->media_ready = true; +} +EXPORT_SYMBOL_NS_GPL(cxl_set_media_ready, CXL); + static int cxl_memdev_release_file(struct inode *inode, struct file *file) { struct cxl_memdev *cxlmd = diff --git a/include/cxl/cxl.h b/include/cxl/cxl.h index e0bafd066b93..6033ce84b3d3 100644 --- a/include/cxl/cxl.h +++ b/include/cxl/cxl.h @@ -56,4 +56,5 @@ bool cxl_pci_check_caps(struct cxl_dev_state *cxlds, int cxl_pci_accel_setup_regs(struct pci_dev *pdev, struct cxl_dev_state *cxlds); int cxl_request_resource(struct cxl_dev_state *cxlds, enum cxl_resource type); int cxl_release_resource(struct cxl_dev_state *cxlds, enum cxl_resource type); +void cxl_set_media_ready(struct cxl_dev_state *cxlds); #endif