| Message ID | 20241122221348.3998-1-jiashengjiangcool@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 77ed2470ac09c2b0a33cf3f98cc51d18ba9ed976 |
| Headers | show |
| Series | [v3,1/2] media: mipi-csis: Add check for clk_enable() | expand |
On 22/11/2024 23:13, Jiasheng Jiang wrote: > Add check for the return value of clk_enable() to gurantee the success. > > Fixes: babde1c243b2 ("[media] V4L: Add driver for S3C24XX/S3C64XX SoC series camera interface") > Signed-off-by: Jiasheng Jiang <jiashengjiangcool@gmail.com> Please version your patches correctly, e.g. use b4 or git format-patch -vX, and add changelog in cover letter or under '---' of individual patches describing changes from previous version. Best regards, Krzysztof
Hi Krzysztof, On Sat, Nov 23, 2024 at 11:00 AM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On 22/11/2024 23:13, Jiasheng Jiang wrote: > > Add check for the return value of clk_enable() to gurantee the success. > > > > Fixes: babde1c243b2 ("[media] V4L: Add driver for S3C24XX/S3C64XX SoC series camera interface") > > Signed-off-by: Jiasheng Jiang <jiashengjiangcool@gmail.com> > Please version your patches correctly, e.g. use b4 or git format-patch > -vX, and add changelog in cover letter or under '---' of individual > patches describing changes from previous version. Thanks for your correction. I have corrected the errors in the Changelog and resent the patch. -Jiasheng
diff --git a/drivers/media/platform/samsung/s3c-camif/camif-core.c b/drivers/media/platform/samsung/s3c-camif/camif-core.c index de6e8f151849..221e3c447f36 100644 --- a/drivers/media/platform/samsung/s3c-camif/camif-core.c +++ b/drivers/media/platform/samsung/s3c-camif/camif-core.c @@ -527,10 +527,19 @@ static void s3c_camif_remove(struct platform_device *pdev) static int s3c_camif_runtime_resume(struct device *dev) { struct camif_dev *camif = dev_get_drvdata(dev); + int ret; + + ret = clk_enable(camif->clock[CLK_GATE]); + if (ret) + return ret; - clk_enable(camif->clock[CLK_GATE]); /* null op on s3c244x */ - clk_enable(camif->clock[CLK_CAM]); + ret = clk_enable(camif->clock[CLK_CAM]); + if (ret) { + clk_disable(camif->clock[CLK_GATE]); + return ret; + } + return 0; }
Add check for the return value of clk_enable() to gurantee the success. Fixes: babde1c243b2 ("[media] V4L: Add driver for S3C24XX/S3C64XX SoC series camera interface") Signed-off-by: Jiasheng Jiang <jiashengjiangcool@gmail.com> --- .../media/platform/samsung/s3c-camif/camif-core.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-)