| Message ID | 20241123123900.2656837-3-csokas.bence@prolan.hu (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Add support for codec of F1C100s | expand |
On Sat, Nov 23, 2024 at 01:39:00PM +0100, Csókás, Bence wrote: > Add compatible string for Allwinner suniv F1C100s audio codec. > > [ csokas.bence: Reimplement Mesih Kilinc's binding in YAML ] > Signed-off-by: Csókás, Bence <csokas.bence@prolan.hu> > --- > .../sound/allwinner,sun4i-a10-codec.yaml | 31 +++++++++++++++++++ > 1 file changed, 31 insertions(+) > Missing changelog - what happened here? If no changes, why ignoring received tag? <form letter> This is a friendly reminder during the review process. It looks like you received a tag and forgot to add it. If you do not know the process, here is a short explanation: Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions, under or above your Signed-off-by tag. Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply. https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 If a tag was not added on purpose, please state why and what changed. </form letter> Best regards, Krzysztof
Hi, On 2024. 11. 23. 17:22, Krzysztof Kozlowski wrote: > On Sat, Nov 23, 2024 at 01:39:00PM +0100, Csókás, Bence wrote: >> Add compatible string for Allwinner suniv F1C100s audio codec. >> >> [ csokas.bence: Reimplement Mesih Kilinc's binding in YAML ] >> Signed-off-by: Csókás, Bence <csokas.bence@prolan.hu> >> --- >> .../sound/allwinner,sun4i-a10-codec.yaml | 31 +++++++++++++++++++ >> 1 file changed, 31 insertions(+) >> > > Missing changelog - what happened here? If no changes, why ignoring > received tag? Sorry, I just forgot to collect it, that's all. > <form letter> > This is a friendly reminder during the review process. > > It looks like you received a tag and forgot to add it. > > If you do not know the process, here is a short explanation: Please add > Acked-by/Reviewed-by/Tested-by tags when posting new versions, under > or above your Signed-off-by tag. Tag is "received", when provided > in a message replied to you on the mailing list. Tools like b4 can help > here. However, there's no need to repost patches *only* to add the tags. > The upstream maintainer will do that for tags received on the version > they apply. > > https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 > > If a tag was not added on purpose, please state why and what changed. > </form letter> > > Best regards, > Krzysztof Bence
On Sat, 23 Nov 2024 13:39:00 +0100, Csókás, Bence wrote: > Add compatible string for Allwinner suniv F1C100s audio codec. > > [ csokas.bence: Reimplement Mesih Kilinc's binding in YAML ] > Signed-off-by: Csókás, Bence <csokas.bence@prolan.hu> > --- > .../sound/allwinner,sun4i-a10-codec.yaml | 31 +++++++++++++++++++ > 1 file changed, 31 insertions(+) > Please add Acked-by/Reviewed-by tags when posting new versions. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply. If a tag was not added on purpose, please state why and what changed. Missing tags: Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/sound/allwinner,sun4i-a10-codec.yaml b/Documentation/devicetree/bindings/sound/allwinner,sun4i-a10-codec.yaml index ebc9097f936a..ccae64ce3071 100644 --- a/Documentation/devicetree/bindings/sound/allwinner,sun4i-a10-codec.yaml +++ b/Documentation/devicetree/bindings/sound/allwinner,sun4i-a10-codec.yaml @@ -23,6 +23,7 @@ properties: - allwinner,sun8i-h3-codec - allwinner,sun8i-v3s-codec - allwinner,sun50i-h616-codec + - allwinner,suniv-f1c100s-codec reg: maxItems: 1 @@ -77,6 +78,7 @@ properties: - MIC1 - MIC2 - MIC3 + - MIC # Microphone Biases from the SoC - HBIAS @@ -87,6 +89,8 @@ properties: - Headset Mic - Line In - Line Out + - Right FM In + - Left FM In - Mic - Speaker @@ -270,6 +274,33 @@ allOf: - const: rx - const: tx + - if: + properties: + compatible: + enum: + - allwinner,suniv-f1c100s-codec + + then: + properties: + allwinner,audio-routing: + items: + enum: + - HP + - HPCOM + - LINEIN + - LINEOUT + - MIC + - HBIAS + - MBIAS + - Headphone + - Headset Mic + - Line In + - Line Out + - Right FM In + - Left FM In + - Mic + - Speaker + unevaluatedProperties: false examples:
Add compatible string for Allwinner suniv F1C100s audio codec. [ csokas.bence: Reimplement Mesih Kilinc's binding in YAML ] Signed-off-by: Csókás, Bence <csokas.bence@prolan.hu> --- .../sound/allwinner,sun4i-a10-codec.yaml | 31 +++++++++++++++++++ 1 file changed, 31 insertions(+)