| Message ID | 20241125174511.45-4-quic_rlaggysh@quicinc.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Add EPSS L3 provider support on SA8775P SoC | expand |
On 25/11/2024 18:45, Raviteja Laggyshetty wrote: > EPSS instance on sc7280, sm8250 SoCs, use PERF_STATE register instead of This should explain that these devices are actually 100% compatible. > REG_L3_VOTE to scale L3 clocks, hence adding a new generic > compatible "qcom,epss-l3-perf" for these targets. Not the best reason... You add one more generic compatible, because devices are different? With such reason answer is: no, do not add generic compatibles, because they are not generic. The entire point of having generic compatibles is that they really are generic. Here you prove that they are not generic, so why creating one more generic compatible which might not be generic at all? I already expressed above concerns multiple times: 1. In previous versions of this patchset 2. In other threads I am not against this change, but I am not going to Ack it. Get acks from other maintainers, I am not happy with multiple generic-but-actually-not-generic compatibles. I think that is poor approach. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml b/Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml index 21dae0b92819..e24399ca110f 100644 --- a/Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml +++ b/Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml @@ -28,12 +28,15 @@ properties: - const: qcom,osm-l3 - items: - enum: - - qcom,sc7280-epss-l3 - qcom,sc8280xp-epss-l3 - qcom,sm6375-cpucp-l3 - - qcom,sm8250-epss-l3 - qcom,sm8350-epss-l3 - const: qcom,epss-l3 + - items: + - enum: + - qcom,sc7280-epss-l3 + - qcom,sm8250-epss-l3 + - const: qcom,epss-l3-perf reg: maxItems: 1
EPSS instance on sc7280, sm8250 SoCs, use PERF_STATE register instead of REG_L3_VOTE to scale L3 clocks, hence adding a new generic compatible "qcom,epss-l3-perf" for these targets. Signed-off-by: Raviteja Laggyshetty <quic_rlaggysh@quicinc.com> --- .../devicetree/bindings/interconnect/qcom,osm-l3.yaml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)